josemarluedke / glimmer-apollo

Ember and Glimmer integration for Apollo Client.
https://glimmer-apollo.com
MIT License
38 stars 14 forks source link

Regression: `Can't resolve 'glimmer-apollo'` after upgrade to `v0.6.3`: unbuilt release lacking a`dist` folder? #93

Closed johanrd closed 1 month ago

johanrd commented 1 month ago

After upgrade to v0.6.3 when used with pnpm+embroider:

Build Error (PackagerRunner) in apollo.ts

Module not found: Error: Can't resolve 'glimmer-apollo' in '~/webapp/UI/console/node_modules/.pnpm/glimmer-apollo@0.6.3_@apollo+client@3.11.8_graphql-ws@5.16.0_graphql@16.9.0__graphql@16.9.0___n4wzpmhzfvjt3j3ql7dvp3rptm/node_modules'

the only reference to glimmer-apollo in app.ts unchanged, and precisely like the docs:

import { setClient } from 'glimmer-apollo';

It seems like the npm release is missing a builld step, as the npm package does not include a dist folder:

Screenshot 2024-10-01 at 17 26 16

environment: "@embroider/compat": "3.6.1", "@embroider/core": "3.4.16", "@embroider/router": "2.1.8", "@embroider/webpack": "4.0.5", "typescript": "^5.6.2", "webpack": "^5.95.0", "ember-source": "5.12.0",