josemarluedke / remark-hbs

Remark plugin that allows writing markdown with Ember handlebars templates
MIT License
6 stars 2 forks source link

failing test for hbs preview-template with nested components #13

Closed NullVoxPopuli closed 3 years ago

josemarluedke commented 3 years ago

This plugin doesn't know anything about preview-templates. Preview templates are specifically a concept of the Docfy Ember.

So, in terms of this plugin, the output should be all escaped HTML, to be rendered in the pre tag.

Looking at the failing test, it seems it is not escaping all the necessary tags, which is a problem.

josemarluedke commented 3 years ago

I just verified that the generated component in Docfy looks correct:

Screen Shot 2021-03-01 at 8 24 15 PM
NullVoxPopuli commented 3 years ago

🤔, I think my issue is actually with auto linking. Thanks!