URL passed as argument in hbs preview-template is converted to a link by autolink plugin

josemarluedke / remark-hbs

Remark plugin that allows writing markdown with Ember handlebars templates

MIT License

6 stars 2 forks source link

Closed NullVoxPopuli closed 3 years ago

NullVoxPopuli commented 3 years ago

idk if there is anything to do about this, but it seems there is maybe an ordering issue? idk, or the auto linker needs to escape arguments?

example:

\`\`\`hbs preview-template
<MyLink @href="https://docfy.dev">
  some text
</MyLink>
\`\`\`

josemarluedke commented 3 years ago

This issue seems to be something similar to #13. This plugin doesn't have any special treatment for preview-template.

In Docfy, this seems to work correctly:

NullVoxPopuli commented 3 years ago

It this test, did you have auto linking?

josemarluedke commented 3 years ago

Yep:

NullVoxPopuli commented 3 years ago

Huh, for me, I had an a tag inserted into my arg. I'll debug a bit tomorrow and see if I can find more details

josemarluedke commented 3 years ago

@NullVoxPopuli Do you still have this problem? Can we close it?

NullVoxPopuli commented 3 years ago

yeah, we can close :D I haven't come across anything similar to this issue in a while