search

josenk / terraform-provider-esxi

Terraform-provider-esxi plugin
GNU General Public License v3.0
544 stars 154 forks source link

Discuss different default guestos OS type #122

Closed dglinder closed 4 years ago

dglinder commented 4 years ago

In this file, the default OS if none is given is "centos-64": https://github.com/josenk/terraform-provider-esxi/blob/86264ae1473e088c6a3275d9ad21859a72e7e44e/esxi/guest-create.go#L106-L108

The VMWare documents don't show that specific entry: https://vdc-download.vmware.com/vmwb-repository/dcr-public/da47f910-60ac-438b-8b9b-6122f4d14524/16b7274a-bf8b-4b4c-a05e-746f2aa93c8c/doc/vim.vm.GuestOsDescriptor.GuestOsIdentifier.html

The provider module ends up setting a problematic OS type ("Other 32bit").

Would the use of "centos8_64Guest" or even "other4xLinux64Guest" be a better modern default? This is only available since vSphere API 6.7, so that might still not be perfect, but presumably more relevant to current users.

dglinder commented 4 years ago

Sorry, ignore this issue - the guest OS names listed in the VMWare.com document do not map directly to the "guestos" variable settings.