search

josenk / terraform-provider-esxi

Terraform-provider-esxi plugin
GNU General Public License v3.0
540 stars 154 forks source link

defer file.Close() after return? #150

Closed rgl closed 2 years ago

rgl commented 2 years ago

The following code seems to have a stray defer file.Close() after a return:

https://github.com/josenk/terraform-provider-esxi/blob/e91bddc8900573f6881e3553e1faeff8010f2edc/esxi/guest-create.go#L270-L271

Is that really the intent?

josenk commented 2 years ago

Yea, that seems wrong... I'll take a look at it when I get a chance. A bit crazy at work these days.

josenk commented 2 years ago

Fixed in V1.9.1