josenk / terraform-provider-esxi

Terraform-provider-esxi plugin
GNU General Public License v3.0
540 stars 154 forks source link

Manage the portgroup security policy #153

Closed rgl closed 2 years ago

rgl commented 2 years ago

This lets us manage the portgroup security policy.

The port group security policy also supports a 3rd state of "Inherit from vSwitch", but I'm not adding support for that. Even though esxcli allows us to inherit each value independently, the ESXi UI will not correctly display/edit the settings, which will confuse the Human operator, so I just ignored that and this will always set the values.

Please note that this also includes https://github.com/josenk/terraform-provider-esxi/pull/152.

BTW, esxcli support outputting the values as CSV, I'm using that here because it simplifies the code. What do you think about using this CSV parsing everywhere?