josenk / terraform-provider-esxi

Terraform-provider-esxi plugin
GNU General Public License v3.0
540 stars 154 forks source link

[BUG] add CheckMACAddress to VMX file to prevent ESXi mac checking #167

Closed jremerich closed 2 years ago

jremerich commented 2 years ago

This PR fix VM power on when mac_address is defined as described in https://github.com/josenk/terraform-provider-esxi/issues/166#issuecomment-1024546891

josenk commented 2 years ago

Sorry, but I wouldn't call this is not a bug... esxi is giving you that error because that mac address is not allowed by default.

https://docs.vmware.com/en/VMware-vSphere/7.0/com.vmware.vsphere.networking.doc/GUID-F9243FED-F081-498F-B4A9-EF950292AF77.html

I'm pretty conservative by default, so I'll need to think about this PR. Why exactly is vmware blocking this range?

Have you tried putting CheckMACAddress in your source ovf files? Hopefully ovftool will migrate it during the cloning process.

josenk commented 2 years ago

Scrap the idea of putting it in your source ovf. I just remembered... Alll networking information is stripped away, so it will be gone.

Why do you need that mac range? Why can't you just use a valid range?

jremerich commented 2 years ago

Sorry, I thought that this was a bug, less bad!

I don't need be this range. I just was following documentation that says that range is for manually generated addresses.

I'll try to create the mac address in another range.

jremerich commented 2 years ago

Hi!

I've created the mac address in another range and worked fine!

VMware has 2 reserved mac ranges:

In fact this PR isn't necessary.

I'm closing it!

Thanks for attention!