search

josenk / terraform-provider-esxi

Terraform-provider-esxi plugin
GNU General Public License v3.0
538 stars 154 forks source link

ReadMe identifies a breaking change at version 1.9.0 #207

Closed ajn142 closed 1 year ago

ajn142 commented 1 year ago

Describe the bug ReadMe file identifies that 1.9.0 changes the default hwversion value from 8 to 13, and this may be a breaking change for older versions of ESXi. It doesn't identify what versions of ESXi this may break.

To Reproduce Steps to reproduce the behavior:

  1. Read the ReadMe.md file for this repository, specifically the line brought up by https://github.com/josenk/terraform-provider-esxi/#:~:text=hwversion

Expected behavior I thought I'd know what versions this would be a breaking change for.

Terraform files N/A

Desktop (please complete the following information): N/A

Additional context

ajn142 commented 1 year ago

I found the vmWare documentation here. Looks like this is a breaking change for versions of ESXi older than 6.5.

https://kb.vmware.com/s/article/1003746

I'll put in a pull request to clarify the ReadMe

josenk commented 1 year ago

merged