search

joseph-grabinger / flutter_to_pdf

Create PDFs but work with normal Flutter Widgets.
MIT License
21 stars 17 forks source link

Fix: Widget args cast types error #77

Closed sousa-p closed 4 months ago

sousa-p commented 4 months ago

I changed some extensions to support certain types of types, such as some conditionals to validate future errors

sousa-p commented 4 months ago

Thanks a lot for your support ❤️ and sorry for the incorrect code

joseph-grabinger commented 4 months ago

Thanks a lot for your support ❤️ and sorry for the incorrect code

No worries - Thank you for the contribution :)

Changes look good - feel free to squash and merge^^

codecov-commenter commented 4 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 85.52%. Comparing base (cb11d2f) to head (a34a56a).

Files Patch % Lines
lib/args/edge_insets.dart 33.33% 8 Missing :warning:
lib/args/alignment.dart 57.14% 3 Missing :warning:
lib/export_delegate.dart 0.00% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #77 +/- ## ========================================== - Coverage 86.65% 85.52% -1.14% ========================================== Files 58 58 Lines 877 898 +21 ========================================== + Hits 760 768 +8 - Misses 117 130 +13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

joseph-grabinger commented 4 months ago

Closes #75

sousa-p commented 4 months ago

image

I'm sorry, but I might not be able to merge it, I don't have access to do so

joseph-grabinger commented 4 months ago

Ah sorry... wasn't aware of that

dumikaiya commented 3 months ago

Is this in production? It's not part of the current version. Any update when it will be on pub.dev?

joseph-grabinger commented 3 months ago

Is this in production? It's not part of the current version. Any update when it will be on pub.dev?

@dumikaiya Thanks for the reminder and sorry for the delay.

The newest version (v0.2.2) which includes this fix is now released to pub.dev. https://pub.dev/packages/flutter_to_pdf/versions/0.2.2