joseph-mudloff / pixie-cms

Automatically exported from code.google.com/p/pixie-cms
Other
0 stars 0 forks source link

Settings pages Slug/URL shows for editing but cannot be edited #13

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Login, click settings tab, click settings for a dynamic page
2. Edit\change Slug/URL to something else make sure the page is in the nav 
and save.
3. Visit the site's front page and click on the link to the page you just 
edited

What is the expected output? What do you see instead?
Slug/URL should not be editable in settings pages.

Results in blank page output.

Additional information :
See :
http://groups.google.com/group/pixie-cms/browse_thread/
thread/8a39a0510ac3c2bf#
We can offer edit for static pages but not for dynamic pages and modules.
I have attempted to prevent the display of the Slug/URL field in lib_core 
but I can only get it so that it removes the ability to change the Slug/
URL in static pages too.
We need the static edits to declare themselves somehow to be able to 
distinguish between the two, then we can conditionally offer the edit only 
on static page settings edits.

In trunk, the relevant places in lib_core of concern are :
line 236
line 252
line 338

I have hashed out above and below each of those lines, part of the fix I 
propose in trunk found in commit r476 or greater.

For each conditional statement of :
if ( ($Nams[$j] != 'page_name') ) {
it should be more like :
if ( ($Nams[$j] != 'page_name') && ($m != 'static' ) {
but that obviously doesn't work because when you edit either a static, 
dynamic or module settings page, the url does not set the $m variable in 
the url.

How can the fact that we are editing a static settings page be defined?

Original issue reported on code.google.com by tonywhit...@googlemail.com on 22 Feb 2010 at 11:48

GoogleCodeExporter commented 8 years ago
Fixed in trunk.
The slug/url field and it's sibling elements are set to display:none using 
inline 
style, if the form is an edit of dynamic page or module. Static page slug/urls 
can 
still be changed on any settings form. You can still set the slug/url for a new 
dynamic page.

Original comment by tonywhit...@googlemail.com on 24 Feb 2010 at 8:01