search

joseph-roitman / pytest-snapshot

A plugin for snapshot testing with pytest.
MIT License
114 stars 12 forks source link

Simplify version #63

Closed rotu closed 8 months ago

rotu commented 1 year ago

Change slightly how version is populated. Increases test coverage to 100% at https://app.codecov.io/gh/joseph-roitman/pytest-snapshot

joseph-roitman commented 8 months ago

Hello, thanks for the PR. I'm planning on moving setuptools_scm to pyproject.toml once support for Python 3.5 is dropped.

Does this change work on Python 3.5? You can check this by running the Github CI action Does from pytest_snapshot import __version__ still work after this change?

rotu commented 8 months ago

I don't know, honestly. I would move forward to at least 3.7 so you can use importlib.resources and don't have to deal with pkg_resources.

Anyway, this PR is not worth merging in - you should instead probably use the instructions here instead.