Open scottfr opened 10 years ago
When tapping a magnifier control, the page turn is not prevented.
This appears to be fixed by changing the magnifier constructor. Specifically changing the listenForTap call in createControlElements to a listenForContact call.
The result is:
function createControlElements(holder) { var btn = holder.dom.make('div', 'controls_magnifier_button'); btn.smallA = btn.dom.append('span', 'controls_magnifier_a', { text: 'A' }); btn.largeA = btn.dom.append('span', 'controls_magnifier_A', { text: 'A' }); p.buttons.push(btn); Monocle.Events.listenForTap(btn, toggleMagnification); return btn; }
Becomes:
function createControlElements(holder) { var btn = holder.dom.make('div', 'controls_magnifier_button'); btn.smallA = btn.dom.append('span', 'controls_magnifier_a', { text: 'A' }); btn.largeA = btn.dom.append('span', 'controls_magnifier_A', { text: 'A' }); p.buttons.push(btn); Monocle.Events.listenForContact(btn, {start:toggleMagnification}); return btn; }
When tapping a magnifier control, the page turn is not prevented.
This appears to be fixed by changing the magnifier constructor. Specifically changing the listenForTap call in createControlElements to a listenForContact call.
The result is:
Becomes: