search

josephburnett / jd

JSON diff and patch
MIT License
826 stars 38 forks source link

Error: undefined: base64EncodedFiles #28

Closed ritmas closed 3 years ago

ritmas commented 3 years ago

With the latest commit installation fails on go1.15.2:

# go version
go version go1.15.2 linux/amd64

# go get github.com/josephburnett/jd
# github.com/josephburnett/jd/web/serve
/root/go/src/github.com/josephburnett/jd/web/serve/serve.go:14:11: undefined: base64EncodedFiles
josephburnett commented 3 years ago

I just started including the web UI in the commandline tool. It's 3 files base64 encoded into a golang source. However that won't happen when you install with go get. Requires make pack-web or another recipe which depends on it.

But you must be able to go get this tool. So I've just checked in the compiled and packed UI. I'll make sure to update it whenever I change the UI: https://github.com/josephburnett/jd/commit/63d6811f752fd32f7f16d6d3686414067fb43006

@ritmas sorry about that! Should be fixed at head now.

josephburnett commented 3 years ago

I figured out how to remove this generated file from version control without breaking go get. https://github.com/josephburnett/jd/commit/05af9a9f74d509338136eacdf0c05bb9e7373397 But let me know if this causes any other problems.