Improve error messages in voidNode, better exit statuses

josephburnett / jd

JSON diff and patch

MIT License

826 stars 38 forks source link

Improve error messages in voidNode, better exit statuses #37

Closed JeffFaer closed 2 years ago

JeffFaer commented 2 years ago

These are a couple cleanups that I found during #36.

Improve the error messages produced by voidNode
Have distinct exit statuses for diffs found vs other, unrecoverable errors

josephburnett commented 2 years ago

I have a few thoughts on how to implement the -populate flag differently: https://github.com/josephburnett/jd/issues/36#issuecomment-974890911

The improved error message and exit code commits are great. Can you separate them so we can land them straight away?

JeffFaer commented 2 years ago

I updated this PR to be just those tangential commits. Let me know if I need to do anything else before you merge those in (I don't use git/github too much anymore these days. My company has switched to a form of mercurial so my git is definitely a little rusty)