search

josephcslater / mousai

Harmonic balance solvers
BSD 3-Clause "New" or "Revised" License
21 stars 11 forks source link

Change files mode to 644 #10

Closed dlax closed 6 years ago

dlax commented 6 years ago

It looks weird to have an executable bit set on all files whereas none of them require it. Perhaps these were created on windows?

So do chmod -x+X -R * to set all files mode to 644.

josephcslater commented 6 years ago

This doesn't show as making any changes at all in the repository (see changed files). These files were all made on my Mac. 


-rwxr-xr-x   1 jslater  admin  1425 Oct  2 12:06 CONTRIBUTING.rst
-rwxr-xr-x   1 jslater  admin  1516 Oct  2 12:06 LICENSE.txt
-rwxr-xr-x   1 jslater  admin  2391 Oct  2 12:06 Makefile
-rwxr-xr-x   1 jslater  admin  2923 Mar 24 21:41 README.rst
drwxr-xr-x   4 jslater  admin   128 Feb 13 18:03 build
drwxr-xr-x   3 jslater  admin    96 Feb 13 18:03 dist
drwxr-xr-x  14 jslater  admin   448 Feb 15 13:50 docs
drwxr-xr-x   5 jslater  admin   160 Feb 12 20:20 mousai
drwxr-xr-x   7 jslater  admin   224 Dec  4 00:14 mousai.egg-info
-rwxr-xr-x   1 jslater  admin   106 Oct  2 12:06 pytest.ini
-rwxr-xr-x   1 jslater  admin    85 Oct  2 12:06 requirements.txt
-rwxr-xr-x   1 jslater  admin   193 Oct  2 12:06 setup.cfg
-rwxr-xr-x   1 jslater  admin  1515 Oct  2 12:06 setup.py
dlax commented 6 years ago

Joseph C. Slater wrote:

This doesn't show as making any changes at all in the repository (see changed files). These files were all made on my Mac.

https://github.com/josephcslater/mousai/pull/10/files shows that file modes have changed in git.

Did you pull my branch or just executed the chmod command I noted above? In the latter case, perhaps chmod doesn't work the same on macos; another way to achieve this is "chmod -R =rw,+X *".

josephcslater commented 6 years ago

I see. This must have to do with the default permissions in my account on my machine. This likely has to do with something I did a long time ago because... I'm a bit amateur regularly. I'll merge the changes, but when/if it happens again, can you help point me to precluding such? I think this will likely just keep coming up as I edit or create files. I have a vague recollection of changing the default on my machine. I've been cloning my machine for well over a decade. It surely has some oddities from then that I don't remember.