Roland Smart Tally with an Invalid IP causes an exception

josephdadams / ProTally

on-screen tally software for use with products like ProPresenter or ProVideoServer, enabling the operator to know when their source is visible on-air in a TSL 3.1 protocol environment, like a Ross Carbonite switcher. It also supports other protocols like Blackmagic's ATEM switcher, Roland Smart Tally, OBS Studio, and Bitfocus Companion.

http://techministry.blog

MIT License

35 stars 3 forks source link

Roland Smart Tally with an Invalid IP causes an exception #2

Closed MichaelAllen closed 5 years ago

MichaelAllen commented 5 years ago

If I try to connect to an invalid IP, or the switcher happens to be turned off, I get an exception that notify.log() is not a function. The only way I have found to get back into the program is to edit the preferences file under ~/Library/ApplicationSupport/ProTally/user-prefernces.json and take out the invalid address.

It looks like the problem is a simple fix. notify.log() should actually be notify(). I will submit a pull request to fix this.

josephdadams commented 5 years ago

Great catch! Thanks! I'll look for your PR and I can release a bugfix build.