search

josephdadams / TallyArbiter

The flexible and customizable camera tally light system
http://www.tallyarbiter.com
MIT License
282 stars 99 forks source link

vibrate when Preview/Live #13

Open Fred-DTV opened 3 years ago

Fred-DTV commented 3 years ago

As we are starting to use TallyArbiter more and more, we've came across an idea which would be really helpful:

At them moment we're using old Smartphones as Tallys for our shows and especially for the non-stationary cams it would be a great feature if the phone would vibrate when the cam is in preview, so the cameraman knows when to get ready even when the phone screen is pointed at the people in front of the cam.

Also the new M5Stick Plus seems to have a buzzer integrated, so it would be useful for that piece as well.

josephdadams commented 3 years ago

Love this idea! I don’t think we will be able to vibrate on iOS/Safari, but possibly other browsers and OS. I’ll look into it.

Fred-DTV commented 3 years ago

btw have you tested your M5 Stick Listener with the new Plus version already? (Not that it really makes a difference because I've already ordered them haha)

josephdadams commented 3 years ago

@DachsbauTV I just got a couple of the Plus models in yesterday (took like a month to get here). I will be working on an updated listener client at some point. I would assume it would work with the existing version but the screen dimensions might be a little off.

Fred-DTV commented 3 years ago

I've just received my M5 Plus Sticks yesterday and I found something really nice on it:

it has a very bright red LED integrated which would be perfect as a tally as well. if that would light up when live, not only the talent would see it but also the camera operator!

josephdadams commented 3 years ago

@DachsbauTV I implemented this but only have iOS devices. Can you test it?

josephdadams commented 3 years ago

Sorry, by this, I mean, the vibration. Not the M5 LED. That's coming.

Fred-DTV commented 3 years ago

Amazing! I will try it either tonight or tomorrow. Any instructions? Does it always vibrate or is there a setting to have the vibrate on preview or live?

I figured it would be cool feature to maybe set a single vibrate to preview and a double to live or vice versa.

Fred-DTV commented 3 years ago

oh and is it already in the main branch? or a seperate download?

josephdadams commented 3 years ago

Yep, main branch. It will do a long vibe when it goes into PGM, and a quick pulse when it goes into PVW.

Fred-DTV commented 3 years ago

I've tried it on two different PC with Win10 now and even though it starts as a service I can't reach the webinterface anymore.

I have completely deleted the folder already (just left the config file) and it didn't change. Also I've reinstalled and updated npm and pm2

Any ideas?

josephdadams commented 3 years ago

Are you sure it's running? Does pm2 give you a log?

josephdadams commented 3 years ago

Also be sure you ran npm install within the Tally Arbiter folder after downloading the latest code. :)

Fred-DTV commented 3 years ago

Ok it is back up and running on both PCs :)

really like the new design!

Tried it now with my Samsung Internet and Chrome on my Samsung phone, but it doesn't vibrate. However i couldn't find the setting to activate the vibration?!

Fred-DTV commented 3 years ago

oh and btw i tried to compile the M5Stick Plusses but no success so far.

Here is the error log: https://paste.sh/Ah-otpOU#2BNM7hwTyYBzi9n5gp7GtfVT

petervcook commented 3 years ago

Does the vibration cause any noticeable camera shake if the phone is mounted to the camera itself?

josephdadams commented 3 years ago

Snap. Didn't think of that. I was just excited to implement something @DachsbauTV asked for. :)

We should make it a toggle option when the user loads the tally page.

And make the "flash" option pulse/vibe as well.

Fred-DTV commented 3 years ago

Yea it would be great to have the option to choose when it should vibrate:

josephdadams commented 3 years ago

It’s on the list!

ReynoldsProductions commented 3 years ago

Following up on this. Is the option for the end user to turn this on and off available yet? My whole build is around tablets and cell phones as the tally lights for talent more than the operator, so the vibration will be more noise and camera shake rather than helpful.

I can't seem to find a variable to turn this feature off.

Thanks!

josephdadams commented 3 years ago

I haven't done any work on it since my last comment. However, since Tally Arbiter runs from source, you can just comment out any of the lines that make it vibrate:

https://github.com/josephdadams/TallyArbiter/blob/f985f1137eb117595c376a564f5a6a9ca22e404a/views/static/lib/js/tally.js#L172

https://github.com/josephdadams/TallyArbiter/blob/f985f1137eb117595c376a564f5a6a9ca22e404a/views/static/lib/js/tally.js#L175

ReynoldsProductions commented 3 years ago

perfect! that worked for me

MatteoGheza commented 3 years ago

@josephdadams can we close this issue? Is there any TODO for this feature?

hrueger commented 3 years ago

I'd say the feature request is disabling the vibration as well as different patterns per bus. In #204 this part is currently completely deactivated in the UI because of the migration from just preview, program and previewprogram to multiple dynamic busses. That means we need to redo that anyway and then we can add an on/off switch as well.