josephdadams / TallyArbiter

The flexible and customizable camera tally light system
http://www.tallyarbiter.com
MIT License
282 stars 99 forks source link

[Bug]: M5Atom Listener uses the wrong colours #361

Open Fred-DTV opened 2 years ago

Fred-DTV commented 2 years ago

What happened?

After successfully getting the Atom connected now to the TA 3.0.1 it works fine.

Just the colours are mixed up.

Preview is pink Program is green

Additionaly in TA test mode turns blue after pvw and pgm.

I was looking through the code to find the problem, but with the new way the colours are calculated, it turned out to be too difficult for me. Sorry :/

P.S.: And the cam number is rotated to the side. Is it possible to specify the rotation somewhere? P.P.S.: Oh and is it possible to change the brightness in the new code somewhere?

Version

3.0.1

Distribution

Desktop

OS

Windows

What browsers are you seeing the problem on?

No response

If applicable, What Listener Clients are You Using?

No response

TallyArbiter configuration

No response

Relevant log output

No response

Error stacktrace (if applicable)

No response

wrldtvlr commented 2 years ago

That color problem has already been addressed. It will show up in the next release or just grab the latest version of the client. Rotating the number would be quite useful but probably should be submitted as an enhancement.

Fred-DTV commented 2 years ago

I've used the .ino from the master branch. Is there a newer version somewhere else?

mg-1999 commented 2 years ago

Atom doesn't really render the default colors well. Try to change the default colors in the settings of the server

wrldtvlr commented 2 years ago

Yes. Use FF00 0000 and 00FF 0000

On Mon, Jan 31, 2022, 13:35 Matthijs @.***> wrote:

Atom doesn't really render the default colors well. Try to change the default colors in the settings of the server

— Reply to this email directly, view it on GitHub https://github.com/josephdadams/TallyArbiter/issues/361#issuecomment-1026135798, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB6FYBQUOGVUXZFS5RBTHILUY3P6LANCNFSM5NGW377A . You are receiving this because you commented.Message ID: @.***>

wrldtvlr commented 2 years ago

I've used the .ino from the master branch. Is there a newer version somewhere else?

Sorry - that should be the working version. There were two problems - the original 3.0 code used an incorrect color order (rgb). This was changed to grb in 3.01. The other problem was @mg-1999 mentioned - the default server color codes don't render very well in the Matrix. In the color picker, try changing the hex codes as suggested above.

Fred-DTV commented 2 years ago

Atom doesn't really render the default colors well. Try to change the default colors in the settings of the server

Ok I will try that, but one more question: If I change the colours in the TA server, then my M5Stick's will have the wrong colour, right? So it isn't possible to use M5Stick and Atom at the same time?

hrueger commented 2 years ago

Well, it should definitely be possible! If you set the colors in the Server UI to bright / full green (#00ff00) and bright / full red (#ff0000) they should be displayed just fine on the hardware clients. Apart from the RGB / GRB issue, every color should render fine in all clients, they just appear differently, because of the physical properties of an RGB LED. It will never look the same way it looks in your monitor.

The default colors in the TA Server are not the bright green / red / blue, because they really hurt your eyes when you look at the web listener for more than 20 seconds ;-)

Does that explaination make sense?

Fred-DTV commented 2 years ago

Alright I am back with an update :)

Changing the colours in the server made the colours look nicer on the Atom as well as the M5Stick, however the colours on the Atom were still inverted.

So I changed this: (swopped r <> g)

// This order is to compensate for Matrix needing grb. int r = colorNumber >> 16; int g = colorNumber >> 8 & 0xFF; int b = colorNumber & 0xFF;

and now everything looks great.

Thanks for all your help!

The-Sizzler commented 2 years ago

+1 for being able to change the brightness! :)