search

josephdadams / TallyArbiter

The flexible and customizable camera tally light system
http://www.tallyarbiter.com
MIT License
287 stars 101 forks source link

[Bug]: Generic UDP action causing crash #662

Open firegood opened 8 months ago

firegood commented 8 months ago

What happened?

I am trying to use Tally Arbiter with my ATEM Constellation 4K to control tally lights on my Sony CR-N500 cameras by emulating VISCA via the generic UDP action.

I found this feature request, which leads me to believe this is possible. I get an error every time the action fires, does not matter the port number, ip address or command I send.

Version

3.0.8

Distribution

Desktop

OS

Windows

What browsers are you seeing the problem on?

Microsoft Edge

If applicable, What Listener Clients are You Using?

Web (Microsoft Edge)

TallyArbiter configuration

"cloud_destinations": [],
  "cloud_keys": [],
  "device_actions": [
    {
      "deviceId": "d4226640",
      "data": {
        "ip": "10.1.74.21",
        "port": 52381,
        "string": "1",
        "end": "",
        "type": "udp4"
      },
      "busId": "e393251c",
      "active": true,
      "outputTypeIdx": "9",
      "outputTypeId": "79e3ce28",
      "id": "1d2b59e9"
    }
  ],
  "device_sources": [
    {
      "deviceId": "d4226640",
      "sourceIdx": "0",
      "address": "1",
      "rename": true,
      "sourceId": "ea40c471",
      "id": "b698c8fb"
    }
  ],
  "devices": [
    {
      "name": "Host Camera",
      "enabled": true,
      "id": "d4226640"
    }
  ],
  "sources": [
    {
      "name": "ATEM 4 M/E Constellation 4K",
      "data": {
        "addresses": [
          "10.1.74.2",
          "ATEM 4 M/E Constellation 4K._blackmagic._tcp.local"
        ],
        "ip": "10.1.74.2",
        "me_onair": [
          "1"
        ],
        "cut_bus_mode": "off"
      },
      "sourceTypeId": "44b8bc4f",
      "reconnect": true,
      "enabled": true,
      "id": "ea40c471",
      "max_reconnects": 5,
      "connected": true
    }
  ],
  "tsl_clients": [],
  "tsl_clients_1secupdate": false,
  "bus_options": [
    {
      "id": "e393251c",
      "label": "Preview",
      "type": "preview",
      "color": "#3fe481",
      "priority": 50
    },
    {
      "id": "334e4eda",
      "label": "Program",
      "type": "program",
      "color": "#e43f5a",
      "priority": 200
    },
    {
      "id": "12c8d699",
      "label": "Aux 1",
      "type": "aux",
      "color": "#0000FF",
      "priority": 100
    },
    {
      "id": "12c8d689",
      "label": "Aux 2",
      "type": "aux",
      "color": "#0000FF",
      "priority": 100
    }
  ],
  "externalAddress": "http://0.0.0.0:4455/#/tally",
  "remoteErrorReporting": false,
  "uuid": "0af26eab"
}

Relevant log output

[2024-03-02 14:55:41] info: Starting OSC Setup.
[2024-03-02 14:55:41] info: Loading the stored Tally Arbiter configuration file.
[2024-03-02 14:55:41] info: Tally Arbiter Sources loaded.
[2024-03-02 14:55:41] info: 1 Sources configured.
[2024-03-02 14:55:41] info: Tally Arbiter Devices loaded.
[2024-03-02 14:55:41] info: 1 Devices configured.
[2024-03-02 14:55:41] info: Tally Arbiter Device Sources loaded.
[2024-03-02 14:55:41] info: 1 Device Sources configured.
[2024-03-02 14:55:41] info: Tally Arbiter Device Actions loaded.
[2024-03-02 14:55:41] info: 1 Device Sources configured.
[2024-03-02 14:55:41] info: TSL Clients 1 Second Updates are turned off.
[2024-03-02 14:55:41] info: Tally Arbiter Cloud Destinations loaded.
[2024-03-02 14:55:41] info: Tally Arbiter Cloud Keys loaded.
[2024-03-02 14:55:41] info: Initiating Setup for Source: ATEM 4 M/E Constellation 4K
[2024-03-02 14:55:41] info: Source: ATEM 4 M/E Constellation 4K Creating Blackmagic ATEM connection.
[2024-03-02 14:55:41] info: Source: ATEM 4 M/E Constellation 4K Creating connection.
[2024-03-02 14:55:41] info: Source: ATEM 4 M/E Constellation 4K Reconnect attempts 5.
[2024-03-02 14:55:41] info: Source: ATEM 4 M/E Constellation 4K Default reconnect timeout: 5000.
[2024-03-02 14:55:41] info: Source: ATEM 4 M/E Constellation 4K Connect triggered at startup.
[2024-03-02 14:55:41] info: Source: ATEM 4 M/E Constellation 4K Closed Blackmagic ATEM connection.
[2024-03-02 14:55:41] info: Source Setup Complete.
[2024-03-02 14:55:41] info: Setting up the Main HTTP Server.
[2024-03-02 14:55:41] info: Main HTTP Server Complete.
[2024-03-02 14:55:41] info: TallyArbiter advertised over MDNS.
[2024-03-02 14:55:41] info: Starting socket.IO Setup.
[2024-03-02 14:55:41] info: Socket.IO Setup Complete.
[2024-03-02 14:55:41] info: Starting Listener Providers.
[2024-03-02 14:55:41] info: Starting VMix Emulation Service.
[2024-03-02 14:55:41] info: Starting TSL Listener Service.
[2024-03-02 14:55:41] info: Initiating 0 TSL Client Connections.
[2024-03-02 14:55:41] info: Finished TSL Client Connections.
[2024-03-02 14:55:41] info: Starting HTTP Server.
[2024-03-02 14:55:41] info: OSC Sending Port Ready. Broadcasting on Port: 5958
[2024-03-02 14:55:41] info: Finished VMix Emulation Setup. Listening for VMix Tally Connections on TCP Port 8099.
[2024-03-02 14:55:41] info: Tally Arbiter running on port 4455
[2024-03-02 14:55:41] info: Source: ATEM 4 M/E Constellation 4K Connected.
[2024-03-02 14:55:41] info: Source: ATEM 4 M/E Constellation 4K Blackmagic ATEM Connection Opened.
[2024-03-02 14:55:41] info: Device discovered on the network: ATEM 4 M/E Constellation 4K (10.1.74.2 / ATEM 4 M/E Constellation 4K._blackmagic._tcp.local)
[2024-03-02 14:55:45] info: Running Actions for Device: Host Camera
[2024-03-02 14:55:45] info: Running action: Host Camera:Preview:Off  1d2b59e9
[2024-03-02 14:55:45] error: Caught exception: TypeError: Cannot read properties of undefined (reading 'action')
[2024-03-02 14:55:55] info: Device Action Edited: Host Camera
[2024-03-02 14:55:55] info: Config file saved to disk.
[2024-03-02 14:55:55] info: Running Actions for Device: Host Camera
[2024-03-02 14:55:55] info: Running action: Host Camera:Preview:On  1d2b59e9
[2024-03-02 14:55:55] error: Caught exception: TypeError: Cannot read properties of undefined (reading 'action')
[2024-03-02 14:55:56] info: Running Actions for Device: Host Camera
[2024-03-02 14:55:56] info: Running action: Host Camera:Preview:On  1d2b59e9
[2024-03-02 14:55:56] error: Caught exception: TypeError: Cannot read properties of undefined (reading 'action')
[2024-03-02 14:55:57] info: Running Actions for Device: Host Camera
[2024-03-02 14:55:57] info: Running action: Host Camera:Preview:On  1d2b59e9
[2024-03-02 14:55:57] error: Caught exception: TypeError: Cannot read properties of undefined (reading 'action')
[2024-03-02 14:55:57] info: Running Actions for Device: Host Camera
[2024-03-02 14:55:57] info: Running action: Host Camera:Preview:On  1d2b59e9
[2024-03-02 14:55:57] error: Caught exception: TypeError: Cannot read properties of undefined (reading 'action')
[2024-03-02 14:55:57] info: Running Actions for Device: Host Camera
[2024-03-02 14:55:57] info: Running action: Host Camera:Preview:On  1d2b59e9
[2024-03-02 14:55:57] error: Caught exception: TypeError: Cannot read properties of undefined (reading 'action')
[2024-03-02 14:55:58] info: Running Actions for Device: Host Camera
[2024-03-02 14:55:58] info: Running action: Host Camera:Preview:On  1d2b59e9
[2024-03-02 14:55:58] error: Caught exception: TypeError: Cannot read properties of undefined (reading 'action')
[2024-03-02 14:55:58] info: Running Actions for Device: Host Camera
[2024-03-02 14:55:58] info: Running action: Host Camera:Preview:On  1d2b59e9
[2024-03-02 14:55:58] error: Caught exception: TypeError: Cannot read properties of undefined (reading 'action')
[2024-03-02 14:56:22] info: Device Action Edited: Host Camera
[2024-03-02 14:56:22] info: Config file saved to disk.
[2024-03-02 14:56:23] info: Running Actions for Device: Host Camera
[2024-03-02 14:56:23] info: Running action: Host Camera:Preview:On  1d2b59e9
[2024-03-02 14:56:23] error: Caught exception: TypeError: Cannot read properties of undefined (reading 'action')
[2024-03-02 14:56:55] info: Running Actions for Device: Host Camera
[2024-03-02 14:56:55] info: Running action: Host Camera:Preview:On  1d2b59e9
[2024-03-02 14:56:55] error: Caught exception: TypeError: Cannot read properties of undefined (reading 'action')
[2024-03-03 14:06:45] info: Device Action Edited: Host Camera
[2024-03-03 14:06:45] info: Config file saved to disk.
[2024-03-03 14:07:17] info: Running Actions for Device: Host Camera
[2024-03-03 14:07:17] info: Running action: Host Camera:Preview:On  1d2b59e9
[2024-03-03 14:07:19] error: An error occured sending the Generic TCP: Error: connect ECONNREFUSED 10.1.74.21:52381
[2024-03-03 14:09:26] info: Device Action Edited: Host Camera
[2024-03-03 14:09:26] info: Config file saved to disk.
[2024-03-03 14:09:32] info: Running Actions for Device: Host Camera
[2024-03-03 14:09:32] info: Running action: Host Camera:Preview:On  1d2b59e9
[2024-03-03 14:09:32] error: Caught exception: TypeError: Cannot read properties of undefined (reading 'action')
[2024-03-03 14:17:33] info: Running Actions for Device: Host Camera
[2024-03-03 14:17:33] info: Running action: Host Camera:Preview:On  1d2b59e9
[2024-03-03 14:17:33] error: Caught exception: TypeError: Cannot read properties of undefined (reading 'action')
[2024-03-03 14:19:02] info: Running Actions for Device: Host Camera

Error stacktrace (if applicable)

TypeError: Cannot read properties of undefined (reading 'action')
    at C:\Users\Production\AppData\Local\Programs\tallyarbiter\resources\app.asar\dist\actions\UDP.js:47:70
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
github-actions[bot] commented 8 months ago

Hello there firegood 👋

Welcome to TallyArbiter!

Thank you for opening your first issue for the Tally Arbiter project. Tally Arbiter fosters an open and welcoming environment for all our contributors. Please adhere to our Code Of Conduct.

If you have more to contribute to this issue, please comment down below! We will try to get back to you as soon as we can.