josephdadams / midi-relay

Listens for HTTP request with JSON payload and relays MIDI/MSC commands on local ports.
MIT License
58 stars 9 forks source link

jQuery loading fix, and CI improvements #30

Closed jkueh closed 2 years ago

jkueh commented 2 years ago

This should resolve the following issues related to loading jQuery in binary builds:

This also adds some GitHub Actions to automatically build and package binaries for distribution on some common platforms.

I had some challenges building for the node16-macos-arm64 target out of the box on my Intel Mac, so I've left that out for now.

Worked out which jQuery file to point to by adding a new route to the Express server:

restServer.use('/js-debug/jquery', function (req, res) {
  let files = fs.readdirSync(path.join(__dirname, 'node_modules', 'jquery', 'dist'))
  res.status(200).send(files.join("\n"));
});
josephdadams commented 2 years ago

@jkueh merging. I never got a notification for this. Sorry! Great work!