search

josephfrazier / reported-web

Web front-end for https://twitter.com/Reported_NYC: https://reported-web.herokuapp.com
https://reported-web.herokuapp.com
MIT License
10 stars 1 forks source link

Don't orient images when submitting, because that strips the EXIF #493

Closed josephfrazier closed 11 months ago

josephfrazier commented 11 months ago

See https://reportedcab.slack.com/archives/GMB2JT5UK/p1701909264481969?thread_ts=1696533043.529419&cid=GMB2JT5UK

alright, i did a little digging, and found out that the reason was that when you're looking at previous submissions, the images would show sideways because chrome had a bug: https://github.com/josephfrazier/Reported-Web/commit/82cd57add26894475e6c8473e02f0936ae0f501f

Orient image by EXIF data before uploading to Parse

This makes them a little friendlier in contexts that don't respect EXIF orientation, such as elements in Chrome.

See https://stackoverflow.com/questions/42401203/chrome-image-exif-orienation-issue

It looks like the chrome bug is marked as fixed: https://bugs.chromium.org/p/chromium/issues/detail?id=56845

but even if it's still broken, it's better to have it be broken and have the EXIF get through, so I'll try to remove the rotation on submission (while keeping it for ALPR, which needs it)