search

josephg / Chipmunk-js

Port of slembcke/Chipmunk-Physics to Javascript
http://dl.dropbox.com/u/2494815/demo/Joints.html
536 stars 59 forks source link

Does not pass google closure advanced mode #16

Closed Wu-Hao closed 11 years ago

Wu-Hao commented 11 years ago

Google closure compiler advanced mode obfuscate codes. commercial release has the need to protect their code

Please look into this to make chipmunk viable for commercial release

josephg commented 11 years ago

You should closure compile your product together with the chipmunk library. Then obfuscation won't break anything.

https://developers.google.com/closure/compiler/docs/api-tutorial3#separately On 21 Dec 2012 13:42, "Wu-Hao" notifications@github.com wrote:

Google closure compiler advanced mode obfuscate codes. commercial release has the need to protect their code

Please look into this to make chipmunk viable for commercial release

— Reply to this email directly or view it on GitHubhttps://github.com/josephg/Chipmunk-js/issues/16.

Wu-Hao commented 11 years ago

this doesn't get past advanced mode: E7 UDUYFFTZ0Y244IDD29PN specifically

SegmentShape.prototype.collisionTable = [
    null,
    function(seg, seg) { return NONE; }, // seg2seg
    seg2poly
];
josephg commented 11 years ago

Oh lol. Submit a pull request please. On 21 Dec 2012 14:02, "Wu-Hao" notifications@github.com wrote:

this doesn't get past advanced mode: [image: E7 UDUYFFTZ0Y244IDD29PN]https://f.cloud.github.com/assets/1455994/26199/7d162fe4-4b1a-11e2-935c-1af6e0bd9dfd.jpg specifically

SegmentShape.prototype.collisionTable = [ null, function(seg, seg) { return NONE; }, // seg2seg seg2poly];

— Reply to this email directly or view it on GitHubhttps://github.com/josephg/Chipmunk-js/issues/16#issuecomment-11601245.

robwalch commented 11 years ago

This is fixed