search

josephg / ShareJS

Collaborative editing in any app
Other
4.97k stars 454 forks source link

return properly formatted response to individual subscribe #373

Closed enjalot closed 9 years ago

enjalot commented 9 years ago

this should fix: https://github.com/derbyjs/racer/issues/205

not sure how to tell what downstream effects this might have. but from what I can tell the way the share client expects things my changes should be correct (to let the Doc handle the subscribe)

enjalot commented 9 years ago

this was not actually the bug, the racer-example was using an old version of browserchannel, and the fall back code doesn't exactly work. the code in question: https://github.com/share/ShareJS/blob/master/lib/client/connection.js#L110