search

josephg / ShareJS

Collaborative editing in any app
Other
4.97k stars 456 forks source link

npm install outdated browser bundle in /dist folder (Windows) #378

Closed Thylossus closed 9 years ago

Thylossus commented 9 years ago

Hi,

While I was trying to resolve an issue in my ShareJS application, I found that the browser bundle in the the ShareJS module's /dist folder is not up-to-date. I hat to run browserify myself to create a bundle based on the newest version (0.7.37).

I assume this problem is caused by Windows not supporting make. However, npm install displays neither a warning nor an error message.

For me this was quite a problem because the doc's _sendOpData function did not assign a sequence number to my operations.

pedrosanta commented 9 years ago

Yep, it seems to be outdated, yes. I've also had issues on #382.

Perhaps @nateps or @josephg could rebuild the lib and republish the package?

pedrosanta commented 9 years ago

Don't know if @jhchen could also do it...

pedrosanta commented 9 years ago

It seems that even on the last version 0.7.39 the dist lib is still outdated, still throwing errors. (Refer to #382)

josephg commented 9 years ago

Ugh. Its because of this change from @Dignifiedquire: 43004c517b489de62db38f6d816d7972d19aad9e

The change rewrote the makefile, removing the webclient target for make. The package.json still tries to build the webclient target in a prepublish step, and thats not happening anymore.

josephg commented 9 years ago

I fixed the problem and published 0.7.40. Please confirm & reopen the issue if its still a problem.

pedrosanta commented 9 years ago

@josephg Works great! Awesome. :+1: :clap: