search

josephg / ShareJS

Collaborative editing in any app
Other
4.97k stars 454 forks source link

Update context 'remove' flag var name to avoid collision with 'text' OT type method #384

Closed pedrosanta closed 9 years ago

pedrosanta commented 9 years ago

Fixes #380.

I've updated the context 'remove' flag var name to 'shouldBeRemoved' as proposed on the discussion of the issue mentioned above. Context remove flag name was updated to avoid collision with the method remove(pos, length, callback) of the 'text' OT type. This collision was causing issues that are documented on the ShareJS GitHub repository, such as #380 and #382.

nateps commented 9 years ago

Thanks!