search

josephg / node-browserchannel

An implementation of a google browserchannel server in node.js
287 stars 47 forks source link

Generate an affinity token by default #43

Closed wenzowski closed 10 years ago

wenzowski commented 10 years ago

continuation of #37

josephg commented 10 years ago

Looks good to me, though I'm curious why the tests are failing

josephg commented 10 years ago

You know you can just update a pull request when you change files - no need to make a new one.

wenzowski commented 10 years ago

yes, but I wanted to remove the compile commit, so this one would be readable

wenzowski commented 10 years ago

the tests are failing because the test suite has been updated but the client hasn't been compiled

wenzowski commented 10 years ago

build kicked off: https://travis-ci.org/josephg/node-browserchannel/builds/19431264

josephg commented 10 years ago

Oh cool - forget I said anything. Looks good!

wenzowski commented 10 years ago

Anything else to add? Changelog maybe?

josephg commented 10 years ago

Thats probably a good idea, but docs don't have to be updated at the same time as the patch. Ship it!