search

josephg / node-foundationdb

Modern Node.js FoundationDB bindings
Other
116 stars 17 forks source link

Directory layer #12

Closed josephg closed 4 years ago

josephg commented 6 years ago

Port the directory layer from the old codebase

ashbrener commented 6 years ago

@josephg what is required here, is it purely a port of the javascript layer to typescript only?

And are we porting from the old node lib or 1 of the other language bindings?

josephg commented 6 years ago

Yeah we need to write a functional typescript version of the directory code on the new promise-based APIs. So either port the old JS or port the code from another binding. It’s all pretty consistent anyway, so I don’t think it matters much.

The other part is to add bindingtester support for the directory layer to test it; which practically speaking means adding a handful of new binding tester operations based on the spec (sorry on my phone - no links while I’m out)

ex3ndr commented 5 years ago

Are you open to pull requests without such tests? Missing directory layer is a deal breaker for me.

josephg commented 5 years ago

No. If the feature is important to you, maybe write some tests so we can all know that the feature is working correctly.

Alternately, if you want a version of this library without tests, feel free to maintain your own fork.

josephg commented 4 years ago

The main work here is done. I'm updating the binding tester now to thrash the code and then I'll release the directory layer, along with a bunch of other changes as 1.0.

josephg commented 4 years ago

Binding tester on the directory layer is passing. (Though I'm going to leave it on overnight to be sure.)

If it all checks out I'm going to cut 1.0 tomorrow with the directory layer 🎉

josephg commented 4 years ago

📦 foundationdb@1.0.0 with directory layer support!