search

josephg / node-foundationdb

Modern Node.js FoundationDB bindings
Other
116 stars 17 forks source link

Support new 6.1 database init flow #23

Closed ryanworl closed 4 years ago

ryanworl commented 5 years ago

https://forums.foundationdb.org/t/upcoming-c-api-changes-planned-for-version-6-1/1058

Looks to be literally just deleting the ceremony for creating the database and replacing with a one-liner

josephg commented 5 years ago

Nice.

node-foundationdb already does that work anyway, so I'll probably just deprecate / remove the createCluster() family of functions, which I've never personally used anyway.

josephg commented 5 years ago

So here's a question: When do I implement this? Doing so will force everyone using the library to update to fdb 6.1+.

ryanworl commented 5 years ago

The old symbols in the C library aren’t going away. You could check what version you’re targeting at runtime.

Sent from my iPhone

On May 7, 2019, at 7:52 PM, Seph Gentle notifications@github.com wrote:

So here's a question: When do I implement this? Doing so will force everyone using the library to update to fdb 6.1+.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

josephg commented 5 years ago

Ah whew. I guess that makes sense. It might make sense to just pave over this part of the API regardless of which API version the user selects.

josephg commented 4 years ago

... Well, waiting a year makes this easier :D. I'm compiling against version 620 of the API and using the new functions. I've stubbed out the API in javascript so people don't have to update their code, though it spits out warning messages if they try.