fix setAPIVersion on native side

josephg / node-foundationdb

Modern Node.js FoundationDB bindings

Other

115 stars 17 forks source link

fix setAPIVersion on native side #31

Closed ex3ndr closed 5 years ago

ex3ndr commented 5 years ago

Wrapping setAPIVersion in native side for compatibility with jest.

ex3ndr commented 5 years ago

Sorry for this mess, but might work now. Not sure how to test this properly since in my setup issue is very flaky.

josephg commented 5 years ago

Great; looks good! Ideally I'd like some unit tests on this (that would make sure this functionality doesn't break in a future version). But for now I'll merge it as-is.

josephg commented 5 years ago

This fixes issue #30