search

josephgardner / isitcg

http://isitcg.com
9 stars 3 forks source link

This ingredient should have been flagged #9

Closed lmgardner closed 6 years ago

lmgardner commented 7 years ago

CERA ALBA/BEESWAX/CIRE DABEILLE,

But because of the way it is written, it wasn't

lmgardner commented 7 years ago

Even with spaces it wasn't flagged ... should be flagged for beeswax

josephgardner commented 7 years ago

Was it supposed to just match bees wax?

https://github.com/josephgardner/isitcg/blob/master/ingredientrules.json#L88

Sent from my iPhone

On Apr 28, 2017, at 1:16 PM, lmgardner notifications@github.com<mailto:notifications@github.com> wrote:

CERA ALBA/BEESWAX/CIRE DABEILLE,

But because of the way it is written, it wasn't

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/josephgardner/isitcg/issues/9, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABPNw6eHYBPrYdpKNXjLL7rqdLnvgN8gks5r0h7lgaJpZM4NLwBL.

josephgardner commented 7 years ago

Ok

lmgardner commented 7 years ago

Oh maybe

Sent from my iPhone

On Apr 28, 2017, at 2:11 PM, josephgardner notifications@github.com<mailto:notifications@github.com> wrote:

Was it supposed to just match bees wax?

https://github.com/josephgardner/isitcg/blob/master/ingredientrules.json#L88

Sent from my iPhone

On Apr 28, 2017, at 1:16 PM, lmgardner notifications@github.com<mailto:notifications@github.commailto:notifications@github.com> wrote:

CERA ALBA/BEESWAX/CIRE DABEILLE,

But because of the way it is written, it wasn't

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/josephgardner/isitcg/issues/9, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABPNw6eHYBPrYdpKNXjLL7rqdLnvgN8gks5r0h7lgaJpZM4NLwBL.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/josephgardner/isitcg/issues/9#issuecomment-298068578, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Aazvi1CZBr03HfuSvDSU_SBKjax91ryCks5r0iu7gaJpZM4NLwBL.

josephgardner commented 7 years ago

Should I treat slashes as commas?

josephgardner commented 7 years ago

Can you verify this is fixed, and close ?

josephgardner commented 6 years ago

Fixed with #63