search

josephhutch / aether

A responsive and clean Hugo theme for blogs
MIT License
146 stars 70 forks source link

include footer #11

Closed andrewharvey closed 5 years ago

josephhutch commented 5 years ago

@andrewharvey, thank you for the pull request. I don't include the footer partial because, well, there is nothing in the footer. Is there any reason you feel the footer should be included? My reasoning behind not including a footer in this theme is that I feel it's unnecessary, especially in a simple blog. Instead, I include the next article and home cards which I feel are more useful.

andrewharvey commented 5 years ago

It's up to you. It's just since you have the file https://github.com/josephhutch/aether/blob/master/layouts/partials/footer.html but it doesn't actually get injected, so perhaps if you don't use the footer just remove that file?

Either way I realised I need to do a fair bit of modifications to get this theme were I'd like it for my purposes so I'll just fork it instead.

Thanks for building and open sourcing this theme.