Closed Saunakghosh10 closed 1 year ago
@Saunakghosh10 After carefully reviewing the updated code, I've noticed some opportunities for improvement. However, I wanted to inquire if you had conducted any testing on this code prior to creating the pull request?
okay
Improvements and fixes made in the code:
Renamed PermissionFlagsBits to Permissions for compatibility. Removed .setDMPermission(false) as it's unnecessary. Fixed the condition for checking role positions. Replaced EmbedBuilder with MessageEmbed for creating embeds. Fixed the use of interaction.reply() and added proper indentation.
Improvements made to the code:
Replaced PermissionFlagsBits.KickMembers with Permissions for compatibility. Removed .setDMPermission(false) as it's unnecessary. Changed .addStringOption() for "messages" to .addIntegerOption() since it expects an integer. Fixed the condition for checking role positions. Replaced EmbedBuilder with MessageEmbed for creating embeds. Simplified the property access for member.user.username and interaction.commandName. Removed unnecessary type conversion with parseInt(). Adjusted indentation and formatting for better readability.