josephlou5 / planet-x-finder

A helper solver for the board game "The Search for Planet X"
https://josephlou5.github.io/planet-x-finder/
MIT License
0 stars 0 forks source link

Survey / Target of Empty Sectors #2

Open artlis321 opened 1 month ago

artlis321 commented 1 month ago

Currently, the options for "Survey" and "Target" refer only to Truly Empty Sectors. However, during actual gameplay, one is only given information about Empty Sectors (which include both Truly Empty Sectors and Planet X).

This should be an easy fix by modifying SectorRule.check to use objects[i] === object || (objects[i] === [[[PLANET_X]]] && object === [[[TRULY_EMPTY]]]) in the places where the comparison is made. One should also modify the UI to reflect the change to surveying Empty Sectors in general (i.e. the dropdown menus for Survey / Target).

josephlou5 commented 1 month ago

I actually had a fix for this in progress from who-knows-when. But honestly I'm thinking that it'll be easier to rewrite the entire script instead of trying to fix it. I kind of don't know what's going on anymore, and I don't like the way I did it before, so maybe this whole thing should be deprecated...