search

josepholim / pe

0 stars 0 forks source link

Inconsistent Error Messages #2

Open josepholim opened 11 months ago

josepholim commented 11 months ago

Editing a contact details but with a large index can give a different error message.

First try:

edit 1000000000 c/add-CS2030

image.png

Second try:

edit 10000000000 c/add-CS2030

image.png

Shouldn't the second try's error message be the same as the first one, as it is error because the index is invalid?

soc-se-bot commented 11 months ago

Team's Response

image.png

An extreme input was entered for your second example. According to the 2nd bullet point above, errors resulting from such situations, i.e. a different error message than expected you shown is not considered a bug.

Moreover, as stated in the screenshot above, this problem is caused by an integer overflow and is hence deemed as an extreme user behaviour.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I do not feel this as a functionality bug, but as a feature flaw.

image.png

Based on the course website, not specific error message can be considered feature flaw.

I agree that your application handled large integers well, since it does not crash or cause the application to break. However, whether or not the input is caused by extreme user behavior, the error message should be consistent and clear enough so that the user is not confused. If the user tries to edit with a large integer index, and get an error message which says that the command format is wrong, the user might think that he/she entered the wrong format, while in fact it is the true format.