nus-se-script
commented
11 months ago Team's Response
Hello! Appreciate the bug. However, we regret to inform you that we have decided to reject this bug.
As NUSCoursemates is targeting NUS SoC students, hence the addresses will be from Singapore.
For your knowledge, Singapore addresses have the following format:
[Block Number] [ Street Name] #[Unit Number]
In Singapore, addresses do not use slashes ("/") in the same way that they might be used in URLs or file paths. Instead, addresses in Singapore typically use a combination of numbers and street names. For example:
123 Main Street
04-567
Singapore 123456
In this example, the street address is "123 Main Street," the unit number is "#04-567," and the postal code is "123456." The use of slashes in addresses is not a common practice in Singapore's addressing system.
In this case, NUSCoursemates will happily accept the above information. However, I do not believe that Baker Street 11, Block e/12 is a valid address in Singapore.
Furthermore, the categorisation of this bug as having medium severity may need reassessment. Given the scarcity, if not absence, of addresses in Singapore that precisely match the conditions triggering the bug, its impact appears to be minimal. Consequently, the inconvenience caused is minor, aligning more with a low severity classification. This reevaluation takes into account the limited real-world impact and underscores the rarity of encountering the specific circumstances in Singapore that lead to this issue.
If the teaching team decides to accept this as a valid bug (for reasons unbeknownst to us), we would categorise it under severity.Low as it would only cause a minor inconvenience to our users on rare occasions.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: I agree with you that Singapore addresses have the format [Block Number] [ Street Name] #[Unit Number], and therefore most users will follow that format.
However, what if there exists a user that is not Singaporean (international student) and is not familiar with Singapore addresses? What if they put their addresses in a different format that includes slashes "/"?
Also, is it possible for an international student in SoC to add a few of their international friends (not living in Singapore) into their contact list? What will happen if the address format is different from the Singapore format?
Lastly, if you think that all addresses keyed in should be in Singapore format, you could add in your user guide about the format requirements for addresses (e.g., not have any slash "/").
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** I do think that this issue is pretty severe. Not only for the reason that I have stated in the other response, but also because of the error message. The error message, instead of telling the user that the address is not a valid address, it tells the user that the email is not a valid email, while the user actually does not input an email. This might cause confusion to the user.
Entering this command: edit 1 a/Baker Street 11, Block e/12 will cause an error message as follows
Where entering this command: edit 1 a/Baker Street 11, Block E/12 is successful
The only difference with those two commands are the small e and the capital E when specifying block letter.