Open josepholim opened 11 months ago
No details provided by team.
[The team marked this bug as a duplicate of the following bug]
Unable to detect duplicate of person with all fields same except for name
A new person can be added as long as the name is different from existing persons in the app, even when all other fields are exactly the same. However, it is almost impossible for 2 different people to have exactly the same details in the real world. The app should warn users that the new person is might be a duplicate.
[original: nus-cs2103-AY2324S1/pe-interim#5255] [original labels: severity.Low type.FeatureFlaw]
[This is the team's response to the above 'original' bug]
It is almost impossible for 2 different people to have exactly the same details in the real world
While it is almost impossible for two unique individuals to share the same details, it does not mean that it is not possible, or impossible for that to happen. In fact, when we take into account international students in NUS, it is much more common in NUS than we think.
We actively explored this idea in our UG. In the
add
command section in our UG, we have:
Addresses: Some NUS students live in halls/ RC/ Residences. The addresses are the same for students living in the same block. NUS also has 'double rooms' and apartment rooms that could accommodate up to a total of 2 and 6 students respectively. It is inevitable for these students to share the same address.
Phone numbers: We could have 2 students in the same household as well, which means that these students will share the same landline. For some international students who have just arrived in Singapore, they may not have an active local mobile number while settling in. This means that they could share mobile numbers with their guardians or closest friends here.
Email addresses: In NUS, when collaborating on a group project, we may create an email account for that specific group project. Students in the same group may share this email address to communicate with others (In fact, this is what we have done for this project)
In research/ studies done in NUS, creating a shared email account is also a common practice. Professors and TAs, who may be SoC students themselves, also occasionally create shared email addresses for course administrative work.However, we do acknowledge that it is unlikely for 2 individuals to share the same telehandle, and instead, we have discussed it in our planned enhancement:
As seen, we have spent a lot of time thinking about duplicate detection. These reasons are not contrived, but they truly reflect the realities of NUS students who, more often than not, have much more in common than we think.
Given the reasons above, we reject this bug report.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
Reason for disagreement: [replace this with your explanation]
Currently, the application allows more than one contact to have the same phone number and email address.
It would be better in the future if the application disallows this, since the user may have accidentally inputted the wrong phone number and not get notified for the duplicate phone number.