josephrcox / easy-reddit-downloader

Simple headless Reddit post downloader
MIT License
78 stars 12 forks source link

FFmpeg not found even when installed. #72

Closed NoExplorer closed 1 year ago

NoExplorer commented 1 year ago

Hello,

I've been trying to test the new feature you've implemented (and customizing it a bit for a different purpose [fixing the Reddit-hosted videos being downloaded with no audio]), but it appears that it doesn't want to work for me because it cannot locate FFmpeg. Tried it on Windows and Linux (EndeavourOS), but it didn't work anywhere.

On Windows 10, it was installed by extracting FFmpeg's files somewhere on the disk and pointing them out in the Environment Variables (PATH).

On Linux (EndeavourOS), it was installed through the package manager (sudo pacman -S ffmpeg, but more or less just updated because it comes pre-installed).

On both systems, I ran npm install ffmpeg at the root directory of where I extracted the program's files.

Where should FFmpeg be installed?

NoExplorer commented 1 year ago

Closing this issue, my script writing skills are awful. The feature works almost OK, videos are downloaded with a low quality preset.

Can I make a repo with my code edits available for everyone, while crediting the original? Will be distributed with the similar license (MIT License)