search

josephsdavid / cord-19-tools

Tools for helping out with COVID-19 research
MIT License
28 stars 7 forks source link

Get all json files in subdirectories #3

Closed JavierPalomares90 closed 4 years ago

JavierPalomares90 commented 4 years ago

The initializer for Paperset() expects all json files to exist in a flat directory. This breaks when passing in /data/custom_license as the directory because the json files exist under 2 directories: /pdf_json and /pdm_json. I updated the Paperset class to look for json files in the directory and any existing subdirectories.

JavierPalomares90 commented 4 years ago

@josephsdavid could you review?

josephsdavid commented 4 years ago

Yes! Sorry rough week working on thesis...

josephsdavid commented 4 years ago

Thanks for the reminder and for helping!

josephsdavid commented 4 years ago

Your changes now on pypi!

JavierPalomares90 commented 4 years ago

Thank you!

From: David Josephs notifications@github.com Sent: Tuesday, April 14, 2020 12:08:41 PM To: josephsdavid/cord-19-tools cord-19-tools@noreply.github.com Cc: Javier Palomares javier.palomares.90@gmail.com; Author author@noreply.github.com Subject: Re: [josephsdavid/cord-19-tools] Get all json files in subdirectories (#3)

Your changes now on pypi!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/josephsdavid/cord-19-tools/pull/3#issuecomment-613565885, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB3YVJEWSGJV2VFTYCBEXCLRMSKBTANCNFSM4MGTGXIQ.