josephsl / wintenApps

Windows App Essentials NVDA add-on
GNU General Public License v2.0
24 stars 9 forks source link

Install tasks: combine unsupported messages into one #78

Closed josephsl closed 1 year ago

josephsl commented 1 year ago

Hi,

Follow-up to #66

Currently there are two "unsupported Windows release" messages: one for Windows 10 (if trying to install the add-on on older Windows releases), and another for feature updates (Windows 10 <= current feature update < supported feature update). #66 addressed the possibility of build range gaps as a result of planned end of support for Windows Server 2022 in 2023 (internally the server version of Windows 10 Version 21H2 and sits between Windows 10 and 11) by presenting a list of supported feature updates for a given Windows 10/11 release. As NV Access is thinking about moving to a newer Python release, and since Python 3.9 and later does not support Windows 7 and 8.0 (8.1 and later are supported), it makes sense to combine these two messages into one to address both scenarios (see above). This also allows translators to translate one less message, hopefully reducing locale data size somewhat (the bulk is actually taken by translated docs, but locale data still matters).

Specifically:

If adopted, this change will be part of Copper 4 development quarter, with the stable release planned for January 2023, coinciding with end of support for Windows 8.1. Just like #66, a phased development approach will be used where a flag will be used to toggle between current and new messages.

Thanks.

josephsl commented 1 year ago

Hi,

Update: toggle flag approach will be gone in October - switching to displaying the new message then. Turns out localization files are updated from time to time via automated translations workflow (I thought it didn't).

Thanks.

josephsl commented 1 year ago

Hi,

As part of this work, change supported builds structure so it will be a single-level dictioanry - it wsa a multi-level dictioanry to differentiate between Windows 10 and 11, but with the combined message listing supported releases Windows series, the current dictioanry no longer makes sense.

Tahnks.

josephsl commented 7 months ago

Hi,

January 2024 update: this work could be partially reverted for consistency with other add-ons - while the list of supported releases will be preserved, only the minimum version will be printed based on the current build.

Thanks.