josephsl / wintenApps

Windows App Essentials NVDA add-on
GNU General Public License v2.0
24 stars 9 forks source link

App modules: unify UIA descendants code under one module #85

Closed josephsl closed 1 year ago

josephsl commented 1 year ago

Hi,

Possibly something to be proposed to NVDA Core in the future:

At the moment there are app modules relying on UIA descendants routine to obtain elements. These include Calculator, Cortana, File Explorer, and Notepad. Changing one part of the routine does not change other parts, requiring manual edits to all affected pp modules. Therefore store the actual routine in a new unified module to be imported from app modules. The obvious advantage is reducing code duplication , with the drawback being changing the routine afects other modules. At the moment the advantage outweighs the drawback as this change could also serve as a prototype for a future NVDA Core change.

Thanks.

josephsl commented 1 year ago

Resolved.