search

josephspurrier / goversioninfo

Golang Microsoft Windows File Properties/Version Info and Icon Resource Generator
MIT License
836 stars 115 forks source link

Fix the example manifest #19 #21

Closed ChristianAEDev closed 6 years ago

ChristianAEDev commented 6 years ago

Pull the tag "assemblyIdentity" up to level to be directly under "assembly". This fixes the "side by side configuration is incorrect" error when using this example in a project. It's the first time I'm using a manifest. Therefore I might overlook why the manifest is as it is. But from what I understand there is no need to declare a dependency. Instead we want to declare the parameter like version for the current project.

With this change the manifest can just be copied and used right away.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 66.783% when pulling 5fff253779084e380511ea3edbdd9972c569be8a on ChristianAEDev:master into 0d8781fedde91283df3f137ce4e8a5545fbc4a7f on josephspurrier:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 66.783% when pulling 5fff253779084e380511ea3edbdd9972c569be8a on ChristianAEDev:master into 0d8781fedde91283df3f137ce4e8a5545fbc4a7f on josephspurrier:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 66.783% when pulling 5fff253779084e380511ea3edbdd9972c569be8a on ChristianAEDev:master into 0d8781fedde91283df3f137ce4e8a5545fbc4a7f on josephspurrier:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 66.783% when pulling 5fff253779084e380511ea3edbdd9972c569be8a on ChristianAEDev:master into 0d8781fedde91283df3f137ce4e8a5545fbc4a7f on josephspurrier:master.

josephspurrier commented 6 years ago

Thank you!