josephwilk / amrita

A polite, well mannered and thoroughly upstanding testing framework for Elixir
201 stars 28 forks source link

Amrita failing with Elixir 1.2 #124

Open lowks opened 8 years ago

lowks commented 8 years ago

Could we have support for Elixir 1.2 pretty please ?

NobbZ commented 8 years ago

Last commit is from 10 months ago, perhaps someone with more time can take it over?

ritalin commented 8 years ago

In elixir 1.1, 3rd arg: tags is introduced for ExUnit.Case.__on_definition__ function but with default value. However this default value is deprecated in elixir 1.2.

Therefore, occurs compiling error.

Short solution is to append 3rd argument for ExUnit.Case.__on_definition__ call.

eg:

ExUnit.Case.__on_definition__(__ENV__, message, [])
lowks commented 8 years ago

In the latest Elixir: 1.3.4 I don't think this is around anymore:

** (UndefinedFunctionError) function ExUnit.Case.__on_definition__/3 is undefined or private
lowks commented 8 years ago

An update on this: http://stackoverflow.com/questions/40478588/how-do-replace-exunit-case-on-definition