User configured global message formatter is never used

[pnevill]

In the example below, I would expect the message "Something went wrong!" to be returned whenever any exception other than a DivideByZeroException is encountered.

           app.UseWebApiGlobalExceptionHandler(x =>
            {
                x.MessageFormatter(exception => JsonConvert.SerializeObject(new
                {
                    error = new
                    {
                        message = "Something went wrong!"
                    }
                }));

                x.ForException<DivideByZeroException>().ReturnStatusCode(HttpStatusCode.BadRequest).UsingMessageFormatter(
                    exception => JsonConvert.SerializeObject(new
                    {
                        error = new
                        {
                            exception = exception.GetType().Name,
                            message = exception.Message
                        }
                    }));
            });

This however doesn't happen, because the HandleExceptionAsync method creates a new instance of DefaultExceptionConfig, which provides its own Formatter.

Removing the Formatter from the DefaultExceptionConfig seems to solve my issue, but may have result in issues for other scenarios.

public class DefaultExceptionConfig : IExceptionConfig
    {
        public HttpStatusCode StatusCode { get; set; }
        public Func<Exception, string> Formatter { get; set; }

        public DefaultExceptionConfig()
        {
            //Formatter = exception => JsonConvert.SerializeObject(new
            //{
            //    error = new
            //    {
            //        exception = exception.GetType().Name,
            //        message = exception.Message
            //    }
            //});
        }
    }

[josephwoodward]

Thanks for raising this, I'll take a look at it.

[josephwoodward]

This has been fixed in the latest version which I'm hoping to release tomorrow, thanks for reporting it!

[pnevill]

Thanks, the new version is working well!

[josephwoodward]

Great! Thanks for reporting the issue in the first place :) I've also added a logging endpoint too.

[pnevill]

Already started using the new logging endpoint that you added - great addition. Thanks again.