search

josephwright / csquotes

Con­text sen­si­tive quo­ta­tion fa­cil­i­ties
LaTeX Project Public License v1.3c
29 stars 18 forks source link

Do not blindly lowercase language names #37

Closed jspitz closed 4 years ago

jspitz commented 4 years ago

Rather than that, only do that if they are completely uppercased (which is probably the cause of a \MakeUppercase e.g. in headings)

This assures mixed-case names such as USenglish are treated correctly

Fixes issue #12.

This revokes https://github.com/josephwright/csquotes/pull/13 which was screwed.

I've addressed https://github.com/josephwright/csquotes/pull/13#commitcomment-21961330

If you dislike the approach in general, feel free to close this.

jspitz commented 4 years ago

The \ifx test here is wrong (comparing the first two tokens of #1 or perhaps a single #1 token to {, etc.

This has been addressed.

josephwright commented 4 years ago

Looks broadly good, though I'd like some groups/private vars. Longer-term, with the expl3 pre-loading plan, I might look to use case folding here. (I should also talk to Javier able babel in this regard.)

jspitz commented 4 years ago

All comments have been addressed.