search

josephwright / csquotes

Con­text sen­si­tive quo­ta­tion fa­cil­i­ties
LaTeX Project Public License v1.3c
28 stars 18 forks source link

\textelp not resetting the space factor #53

Closed eg9 closed 3 years ago

eg9 commented 3 years ago

The macro \textelp is defined via \textellipsis, which leaves after it the space factor of the period, which is correct, because \textellipsis can be used to end a sentence.

On the other hand, \textelp should never be sentence ending.

Example with proposed fix:

\documentclass{article}
\usepackage{csquotes}

\begin{document}

\xspaceskip=20pt % to make the spacing more evident

% this is the default definition
% \newcommand{\mktextelp}{[\textellipsis\unkern]}
% \newcommand{\mktextelpins}[1]{[\textellipsis\unkern] [#1]}

Lorem ipsum \textelp{} sit amet

Lorem ipsum \textelp{x} sit amet

% the fix
\renewcommand{\mktextelp}{[\textellipsis\unkern]\@}
\renewcommand{\mktextelpins}[1]{[\textellipsis\unkern\@] [#1]}

Lorem ipsum \textelp{} sit amet

Lorem ipsum \textelp{x} sit amet

\end{document}
image

Reference: https://tex.stackexchange.com/q/583216/4427

eg9 commented 3 years ago

Sorry for having misplaced the report. I know this might be considered as a breaking change. On the other hand, this has always been wrong.