joseramonc / multi-cursor

:tada:
MIT License
44 stars 7 forks source link

existing atom key bindings #10

Closed jacekkopecky closed 9 years ago

jacekkopecky commented 9 years ago

I just became aware that Atom has its own commands, editor:add-selection-above and ...-below with key bindings different from multi-cursor's. Perhaps this package could use/override the default key bindings from Atom?

wolftune commented 9 years ago

I vote for use the existing key bindings rather than override with these extra complex ones.

jacekkopecky commented 9 years ago

@wolftune ah, right - I meant use the existing Atom key bindings but override their default action with the functionality from multi-cursor Is that what you mean too?

wolftune commented 9 years ago

@jacekkopecky yes, except that in the cases where the actions are the same, obviously there's nothing to override.

jacekkopecky commented 9 years ago

Ah but you are mistaken sir, the actions aren't quite the same. :smile:

multi-cursor's adding of selections can also remove selections (try going up and then down - Atom will keep adding, multi-cursor allows you to correct the selections when you've overdone it).

wolftune commented 9 years ago

ah nice, but yes, it should just replace the existing keybinding, not use a new additional more complex one.

joseramonc commented 9 years ago

Overriding those commands sounds good to me, I wasn't aware of those commands by atom, this would be resolved just by changing the default keybindings to the atom's keybindings?

wolftune commented 9 years ago

I think so, yes, it means one less key to deal with. Potentially, the four-modifier options could then be switched to three.

joseramonc commented 9 years ago

Fixed by #13