remove skipUp and skipDown, proposal for simplier keybindings

[joseramonc]

@jacekkopecky @wolftune This overrides the default keybindings provided by atom for expanding cursor, this may cause problems with OSX at least, but people can always override their keybindings to old ones, or remove OS global shortcuts, with this new keybindings #11 might get fixed too.

Also removes skipUp and skipDown since move-last-cursor-* actions are better for moving cursor around.

Do you have any better options or conflicts with this keybindings?

[jacekkopecky]

Since platform key bindings differ in core Atom, I wonder if there's a way of making them differ in packages as well. On Mac, the expand bindings are on ctrl-shift-up/down.

I won't miss skipUp/skipDown; perhaps, though, you could first remove the key bindings for these operations in one release, give users time to complain, and then if nobody does, nuke the code in some later release (which can then remove all the mentions of skipCount).

[wolftune]

agreed with statements above.

note that there's some basic syntax in Atom for specifying different keybindings for different operating systems. Also, you can specify different keybindings to use when other plugins are installed even. I've seen those situations in other cases.

[joseramonc]

I updated the keybindings per plataform, leaving mac with just ctrl-* because it has OS keybindings on ctrl-shift-* by default. Does this new keybindings works without problems on linux?

[wolftune]

Actually, the Atom default is alt-shift not ctrl-shift

[jacekkopecky]

@joseramonc can you please point me to the Mac key bindings? I'd like to see what you mean by "OS keybindings on ctrl-shift-*".

[jacekkopecky]

@wolftune please specify the platform when talking about defaults - I was talking about Mac bindings, see the source

[wolftune]

@jacekkopecky I was writing specifically to @joseramonc to indicate that the Linux bindings for the built-in operations are alt-shift (whereas the PR here uses ctrl-shift)

[joseramonc]

@jacekkopecky This are the mac settings showing global keyboard shortcuts screen

I'll update the keymap to override atom's plataform default keybinding for editor:add-selection-above and below

[joseramonc]

I have updated them again, are they good now?

[wolftune]

@joseramonc that's right now, that successfully replaces the default keybindings for Linux

[jacekkopecky]

@joseramonc on your screenshot, I see that ctrl-arrows are taken, that's right. The default binding in Atom for these actions are therefore

  'ctrl-shift-up': 'editor:add-selection-above'
  'ctrl-shift-down': 'editor:add-selection-below'

as seen here I think it's these two that multi-cursor should use on darwin.

[joseramonc]

@jacekkopecky Yes but for some reason if you press ctrl-shift-up it triggers mission control but in slow motion, and the same is true for Application Windows, the only way to change this behavior and make atom's editor:add-selection-.. work is by deactivating or changing the mission control and application windows shortcuts.

I used those commands on darwin because I want this package to always work when installed. Adding the override in addition to current darwin command seems the right thing for me.

[jacekkopecky]

Ah, I forgot about the shift slowing; I must have disabled ctrl-up and down for OSX stuff a long time ago. What you wrote sounds right, then.