joseramonc / multi-cursor

:tada:
MIT License
44 stars 7 forks source link

Working great until recently #49

Closed softwarecreations closed 4 years ago

softwarecreations commented 4 years ago

I've been using this plugin for years. Recently it stopped working. I try the default key-bindings (that are definitely enabled) but nothing happens at all. My various other plugins that also use keybindings, that I've also had installed for years are still working fine. I haven't changed any plugin installation status in many months.

Atom 1.40.1 x64 on Linux multi-cursor 3.0.0

joseramonc commented 4 years ago

Hello! I'm sorry for this, I suspect this is a keybinding issue (changed recently)

Could you show me what key bind is resolving please? (You can check this via the key binding resolver). it should show something like this:

image

Also, if the multicursor keybinds are overrided by your keymap?

softwarecreations commented 4 years ago

Hi @joseramonc no worries my friend. Thanks for your reply :)

EDIT Wow, I'm sorry. I feel really dumb now :) I just noticed that I had old keybindings above in my keymap.cson that I had forgotten about.

 'alt-shift-up':     'multi-cursor:expandUp';
 'alt-shift-down':   'multi-cursor:expandDown';

They were the entire cause of the problem. It looks like you've renamed the functions from expandUp to expand-up and expandDown to expand-down. So my binding was triggering but couldn't find the function anymore since you (probably) changed it?

Anyways, the rest was of this message was my debugging, which I'll leave here incase anyone else is interested in my alternative keybinding successes and failures.


This is what the keybinding resolver looks like with the default keybindings and no custom keybindings related to multi-cursor image

I've got the default keybindings enabled, as always image

As an experiment I just created a random key-binding to test, and it works: 'ctrl-alt-i': 'multi-cursor:expand-down'

So I did more experiments now: These don't work 'alt-shift-down': 'multi-cursor:expand-down' 'alt-down': 'multi-cursor:expand-down' 'ctrl-down': 'multi-cursor:expand-down'

This works 'alt-shift-2': 'multi-cursor:expand-down' (using numpad)

Okay I found a workaround: (this works) 'ctrl-alt-shift-down': 'multi-cursor:expand-down' Looks like this image

'shift-ctrl-down': 'multi-cursor:expand-down' also works image

ctrl-shift-down is arguably nicer (easier to press) than alt-shift-down so I'm perfectly happy with this. However it's not nice that the keybindings don't seem to work with the default keybindings that the package comes with.

softwarecreations commented 4 years ago

Also, check out the multi-cursor-increment package with the following keybindings; they synergize nicely. (multi-cursor default keybindings disabled)


  'alt-shift-up': 'multi-cursor:expand-up'
  'alt-shift-down': 'multi-cursor:expand-down'
  'ctrl-shift-up': 'multi-cursor-increment:increment'
  'ctrl-shift-down': 'multi-cursor-increment:decrement'```
joseramonc commented 4 years ago

Glad you solved it! Yes those keybidings names were refactored recently to use the same conventions for all multi-cursor commands.

Thanks for all the detailed information!