RS 1.3.4 to 1.4 conversion is broken

SlimeDog commented 7 months ago

After conversion, I do not see my scoreboard.

In RS 1.3.4 it looked like this (config.yml)

  Scoreboard:
    world:
      default:
        Switch-Timer: 35
        Boards:
          admin:
            Title:
              - '&7□□□□□□□□ &l%server_name%&r&7 □□□□□□□□'
            Lines:
              - '&8world:    &7%multiverse_world_alias%'
              - '&8location: &7%player_x% %player_y% %player_z%'
              - '&8chunk:    &7%coordinatetool_chunk%'
              - '&8region:   &7%coordinatetool_file%'
              - '&8b_biome:  &7%biomeremap_biome_name%'
              - '&8p_biome:  &7%player_biome%'
              - '&8time:     &7%player_world_time_24%'
              - '&8tps:      &7%server_tps_1% %server_tps_5%'
              - ''
              - '&8health:   &7%player_health%'
              - '&8deaths:   &7%statistic_deaths% (%plan_player_death_count%)'
              - '&8points$:  &7%vault_eco_balance%'
              - '&8group:    &7%luckperms_primary_group_name%'
Version: 15

After conversion to 1.4, it looks like this (scoreboards.yml)

Version: 1
Scoreboards:
  default:
    Default: false
    Default-World: world
    Display-Name: '&7default'
    Permission: none
    Refresh:
      Scoreboard: 20
      Title: 20
      Title-Loop-Delay: 20
      Board-Loop-Delay: 30
    Boards:
      Board1:
        Title:
        - '&bRealScoreBoard'
        - '&6> &9RealScoreBoard &6<'
        - '&a>&6> &bRealScoreBoard &6<&a<'
        - '&6> &9RealScoreBoard &6<'
        Lines:
        - '%blank%'
        - ' &7Name: &f%playername% &8| &f%ping%'
        - ' &f%day% &8| &f%time%'
        - ' &7Money: &f%money% &8| &7XP: &f%xp%'
        - ' &7Location:'
        - ' &fX %x% Y %y% Z %z%'
        - '%blank%'
        - '  &fThis is Board &e#1'
        - '%blank%'
        - ' &7RAM: &f%ram%'
        - ' &7Online: &f%online%&8/&f%maxplayers%'
        - '%blank%'
      Board2:
        Title:
        - '&bStatistics &aBoard'
        - '&aStatistics &bBoard'
        Lines:
        - '%blank%'
        - ' &7Stats'
        - '  &fKills: %kills% &7| &fKD: %kd%'
        - '  Mob Kills: %mobkills%'
        - '  Deaths: %deaths%'
        - '  Jumps: %jumps%'
        - '%blank%'
        - ' &fThis is Board &e#2'
        - '%blank%'
    Title:
    - '&7□□□□□□□□ &l%server_name%&r&7 □□□□□□□□'
    Lines:
    - '&8world:    &7%multiverse_world_alias%'
    - '&8location: &7%player_x% %player_y% %player_z%'
    - '&8chunk:    &7%coordinatetool_chunk%'
    - '&8region:   &7%coordinatetool_file%'
    - '&8b_biome:  &7%biomeremap_biome_name%'
    - '&8p_biome:  &7%player_biome%'
    - '&8time:     &7%player_world_time_24%'
    - '&8tps:      &7%server_tps_1% %server_tps_5%'
    - ''
    - '&8health:   &7%player_health%'
    - '&8deaths:   &7%statistic_deaths% (%plan_player_death_count%)'
    - '&8points$:  &7%vault_eco_balance%'
    - '&8group:    &7%luckperms_primary_group_name%'
  test:
    Default: false
    Default-World: world
    Display-Name: '&aTest Board'
    Permission: realscoreboard.testboard
    Refresh:
      Scoreboard: 1
      Title: 20
      Title-Loop-Delay: 10
    Title:
    - '&#50fb00R&#6df700S&#8af300B &#a7f000T&#c3ec00E&#e0e800S&#fde400T'
    - '&#f600fbR&#f700d1S&#f800a7B &#fa007eT&#fb0054E&#fc002aS&#fd0000T'
    Lines:
    - '%blank%'
    - '&7Player: %rainbow% %displayname% &8| &7Ping: &f%ping%'
    - '&7Health: &f%life%/%lifeheart% &8| &7Food: &f%playerfood%'
    - '&7World: &f%world% &8| &7Time: &f%time%'
    - '&7Money: &f%money% &8| &7XP: &f%xp%'
    - '%blank%'
    - '&7Location: &fX %x%, Y %y%, Z %z%'
    - '&7Facing: &fYaw %yaw% Pitch %pitch%'
    - '%blank%'
    - '&7IP: &f%serverip% &8| &7Port: &f%port%'
    - '&7Version: &f%version%'
    - '&7Players: &f%online%/%maxplayers% &8| &7RAM: &f%ram%'
    - '%blank%'

I do not want Board1 or Board2 or test. I would like my scoreboard -- formerly called admin -- to be displayed. What do I need to do?

SlimeDog commented 7 months ago

And on server restart

[16:58:59] [Server thread/ERROR]: [RealScoreboard] world doesn't have a default scoreboard set!

joserodpt commented 7 months ago

Hi there! Thanks for reporting this issue. If you can please continue to test the conversion system and if you know about coding, make a pull request! I will try to fix it as soon as possible.

SlimeDog commented 7 months ago

From the default scoreboards.yml I was able to guess at reasonable content. I manually edited scoreboards.yml to read

Version: 1
Scoreboards:
  default:
    Default: true
    Default-World: world
    Display-Name: '&fDefault Board'
    Permission: none
    Refresh:
      Scoreboard: 3
      Title: 20
      Title-Loop-Delay: 3
      Board-Loop-Delay: 20
    Boards:
      admin:
        Title:
        - '&7□□□□□□□□ &l%server_name%&r&7 □□□□□□□□'
        Lines:
        - '&8world:    &7%multiverse_world_alias%'
        - '&8location: &7%player_x% %player_y% %player_z%'
        - '&8chunk:    &7%coordinatetool_chunk%'
        - '&8region:   &7%coordinatetool_file%'
        - '&8b_biome:  &7%biomeremap_biome_name%'
        - '&8p_biome:  &7%player_biome%'
        - '&8time:     &7%player_world_time_24%'
        - '&8tps:      &7%server_tps_1% %server_tps_5%'
        - ''
        - '&8health:   &7%player_health%'
        - '&8deaths:   &7%statistic_deaths% (%plan_player_death_count%)'
        - '&8points$:  &7%vault_eco_balance%'
        - '&8group:    &7%luckperms_primary_group_name%'

That is nothing like what was produced by the conversion.

In RS 1.3.4, permission scoreboard.admin was required to display this board. Do I need to adjust the Permission node above to enforce that? In addition, I do not know what the following do

Default-World
Display-Name
Refresh.Title-Loop-Delay
Refresh.Board-Loop-Delay

Please advise, and please update the tutorials to reflect the new file content.

SlimeDog commented 7 months ago

While you're in the code, a minor inconsistency

> realscoreboard reload
[17:36:44 INFO]: [RealScoreboard] Loaded 1 scoreboards.
[17:36:44 INFO]: RealScoreboard | The config has been reloaded.

should be

> realscoreboard reload
[17:36:44 INFO]: [RealScoreboard] Loaded 1 scoreboards.
[17:36:44 INFO]: [RealScoreboard] The config has been reloaded.

joserodpt commented 7 months ago

While you're in the code, a minor inconsistency

> realscoreboard reload
[17:36:44 INFO]: [RealScoreboard] Loaded 1 scoreboards.
[17:36:44 INFO]: RealScoreboard | The config has been reloaded.

should be

> realscoreboard reload
[17:36:44 INFO]: [RealScoreboard] Loaded 1 scoreboards.
[17:36:44 INFO]: [RealScoreboard] The config has been reloaded.

What's the inconsistency? The [RealScoreboard] without the brackets?

joserodpt commented 7 months ago

I will look into these things as soon as I have time, thank you so much for reporting!

SlimeDog commented 7 months ago

What's the inconsistency? The [RealScoreboard] without the brackets?

Exactly.

PanetiX commented 7 months ago

For me the same. No player sees the scoreboard. I need to enter /sb setsb default PLAYER then the player need to enter /sb toggle twice but after rejoining the server the scoreboard is lost again and need to make the same procedure.

This is my scoreboard.yml

Version: 1 Scoreboards: default: Default: true Default-World: world Display-Name: '&7default' Permission: none Refresh: Scoreboard: 20 Title: 20 Title-Loop-Delay: 20 Board-Loop-Delay: 30 Title:

'&9&lCitybuild &2| &aOnline: &f%cmi_server_online%' Lines:

'&8 ⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊'

'&2 ▎ &a&lInformationen:'

'&2 ▎ &7Name: &a%cmi_user_name%'

'&2 ▎ &7Rang: &a%cmi_user_prefix%'

'&2 ▎ &7Taler: &a%cmi_user_balance_formatted%'

'&2 ▎ &7Spielzeit: &f%cmi_user_playtime_days% Tage %cmi_user_playtime_hours% Std.'

'&2 ▎ &7Quests: &f%quests_completed%/366'

'&2 ▎ &7Welt: &f%multiverse_world_alias%'

'%blank%'

'&6 ▎ &a&lBooster:'

'&6 ▎ &7Fly: %booster_fly_status% &f| &7Break: %booster_break_status% &f| &7XP: %booster_xp_status%'

'&6 ▎ &r%conditionaltext_booster-score-fly%%conditionaltext_booster-score-break%%conditionaltext_booster-score-xp%'

'%blank%'

'&b ▎ &ediscord.craftplay.de' admin: Default: false Default-World: world Display-Name: '&7admin' Permission: realscoreboard.scoreboardadmin Refresh: Scoreboard: 20 Title: 20 Title-Loop-Delay: 20 Title:

'&9&lCitybuild &2| &aOnline: &f%cmi_server_online%' Lines:

'&8 ⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊'

'&2 ▎ &a%cmi_user_name% &f| &a%cmi_user_prefix% %cmi_user_vanished_symbol%'

'&2 ▎ &7Taler: &a%cmi_user_balance_formatted%'

'&2 ▎ &7Spielzeit: &f%cmi_user_playtime_days% Tage %cmi_user_playtime_hours% Std.'

'&2 ▎ &7Quests: &f%quests_completed%/366'

'&2 ▎ &7Welt: &f%multiverse_world_alias%'

'%blank%'

'&6 ▎ &a&lBooster:'

'&6 ▎ &7Fly: %booster_fly_status% &f| &7Break: %booster_break_status% &f| &7XP: %booster_xp_status%'

'&6 ▎ &r%conditionaltext_booster-score-fly%%conditionaltext_booster-score-break%%conditionaltext_booster-score-xp%'

'%blank%'

'&c ▎ &7Uptime: &f%cmi_server_uptime%'

'&c ▎ &7TPS: &f%server_tps_1_colored% &2| &7RAM: &f%server_ram_used%'

'&c ▎ &7Chunks: &f%server_total_chunks%'

before the update everything works fine.

joserodpt commented 7 months ago

Hi there, please kindly test this version and give me feedback, thanks: RealScoreboard.jar.zip

joserodpt commented 7 months ago

For me the same. No player sees the scoreboard. I need to enter /sb setsb default PLAYER then the player need to enter /sb toggle twice but after rejoining the server the scoreboard is lost again and need to make the same procedure.

This is my scoreboard.yml

Version: 1 Scoreboards: default: Default: true Default-World: world Display-Name: '&7default' Permission: none Refresh: Scoreboard: 20 Title: 20 Title-Loop-Delay: 20 Board-Loop-Delay: 30 Title:

'&9&lCitybuild &2| &aOnline: &f%cmi_server_online%' Lines:

'&8 ⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊'

'&2 ▎ &a&lInformationen:'

'&2 ▎ &7Name: &a%cmi_user_name%'

'&2 ▎ &7Rang: &a%cmi_user_prefix%'

'&2 ▎ &7Taler: &a%cmi_user_balance_formatted%'

'&2 ▎ &7Spielzeit: &f%cmi_user_playtime_days% Tage %cmi_user_playtime_hours% Std.'

'&2 ▎ &7Quests: &f%quests_completed%/366'

'&2 ▎ &7Welt: &f%multiverse_world_alias%'

'%blank%'

'&6 ▎ &a&lBooster:'

'&6 ▎ &7Fly: %booster_fly_status% &f| &7Break: %booster_break_status% &f| &7XP: %booster_xp_status%'

'&6 ▎ &r%conditionaltext_booster-score-fly%%conditionaltext_booster-score-break%%conditionaltext_booster-score-xp%'

'%blank%'

'&b ▎ &ediscord.craftplay.de' admin: Default: false Default-World: world Display-Name: '&7admin' Permission: realscoreboard.scoreboardadmin Refresh: Scoreboard: 20 Title: 20 Title-Loop-Delay: 20 Title:

'&9&lCitybuild &2| &aOnline: &f%cmi_server_online%' Lines:

'&8 ⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊'

'&2 ▎ &a%cmi_user_name% &f| &a%cmi_user_prefix% %cmi_user_vanished_symbol%'

'&2 ▎ &7Taler: &a%cmi_user_balance_formatted%'

'&2 ▎ &7Spielzeit: &f%cmi_user_playtime_days% Tage %cmi_user_playtime_hours% Std.'

'&2 ▎ &7Quests: &f%quests_completed%/366'

'&2 ▎ &7Welt: &f%multiverse_world_alias%'

'%blank%'

'&6 ▎ &a&lBooster:'

'&6 ▎ &7Fly: %booster_fly_status% &f| &7Break: %booster_break_status% &f| &7XP: %booster_xp_status%'

'&6 ▎ &r%conditionaltext_booster-score-fly%%conditionaltext_booster-score-break%%conditionaltext_booster-score-xp%'

'%blank%'

'&c ▎ &7Uptime: &f%cmi_server_uptime%'

'&c ▎ &7TPS: &f%server_tps_1_colored% &2| &7RAM: &f%server_ram_used%'

'&c ▎ &7Chunks: &f%server_total_chunks%'

before the update everything works fine.

Please retry the conversion with the jar provided above this message

SlimeDog commented 7 months ago

RS 1.4.1

Better. Conversion produced

#✦------------------------------------------------------✦
#|                   Scoreboard Config                   |
#✦------------------------------------------------------✦
# RealScoreboard created by joserodpt and maintained by Neziw
# Parameter explanation:
# - Default: if the scoreboard is the default one, doesn't require a permission
# - Default-World: the default world where the scoreboard appears
# - Display-Name: used for GUI and other purposes.
# - Refresh-Scoreboard: the main refresh delay for the whole scoreboard
# - Refresh-Title: refresh delay only for the scoreboard title
# - Title-Loop-Delay: loop delay for the title animation task
# - Board-Loop-Delay: loop delay for the bards switching task (if the scoreboard has multiple boards)
Version: 2
Scoreboards:
  test:
    Default: false
    Default-World: world
    Display-Name: '&aTest Board'
    Permission: realscoreboard.testboard
    Refresh:
      Scoreboard: 1
      Title: 20
      Title-Loop-Delay: 10
    Title:
    - '&#50fb00R&#6df700S&#8af300B &#a7f000T&#c3ec00E&#e0e800S&#fde400T'
    - '&#f600fbR&#f700d1S&#f800a7B &#fa007eT&#fb0054E&#fc002aS&#fd0000T'
    Lines:
    - '%blank%'
    - '&7Player: %rainbow% %displayname% &8| &7Ping: &f%ping%'
    - '&7Health: &f%life%/%lifeheart% &8| &7Food: &f%playerfood%'
    - '&7World: &f%world% &8| &7Time: &f%time%'
    - '&7Money: &f%money% &8| &7XP: &f%xp%'
    - '%blank%'
    - '&7Location: &fX %x%, Y %y%, Z %z%'
    - '&7Facing: &fYaw %yaw% Pitch %pitch%'
    - '%blank%'
    - '&7IP: &f%serverip% &8| &7Port: &f%port%'
    - '&7Version: &f%version%'
    - '&7Players: &f%online%/%maxplayers% &8| &7RAM: &f%ram%'
    - '%blank%'
  default:
    Default: true
    Default-World: world
    Display-Name: '&7default'
    Permission: none
    Refresh:
      Scoreboard: 20
      Title: 20
      Title-Loop-Delay: 20
    Title:
    - '&7□□□□□□□□ &l%server_name%&r&7 □□□□□□□□'
    Lines:
    - '&8world:    &7%multiverse_world_alias%'
    - '&8location: &7%player_x% %player_y% %player_z%'
    - '&8chunk:    &7%coordinatetool_chunk%'
    - '&8region:   &7%coordinatetool_file%'
    - '&8b_biome:  &7%biomeremap_biome_name%'
    - '&8p_biome:  &7%player_biome%'
    - '&8time:     &7%player_world_time_24%'
    - '&8tps:      &7%server_tps_1% %server_tps_5%'
    - ''
    - '&8health:   &7%player_health%'
    - '&8deaths:   &7%statistic_deaths% (%plan_player_death_count%)'
    - '&8points$:  &7%vault_eco_balance%'
    - '&8group:    &7%luckperms_primary_group_name%'

which looks correct except that the

  default:
    Refresh:
      Scoreboard: 20

should be

  default:
    Refresh:
      Scoreboard: 3

Also, it is still the case that the active scoreboard (default) is not displayed for a player until

/realscoreboard setsb default <player>
/realscoreboard toggle
/realscoreboard toggle

and is displayed only for the current session. The command sequence must be repeated for each session in order for the scoreboard to display.

SlimeDog commented 7 months ago

What is the purpose of these lines in config.yml

  Vanish-Commands:
    - pv
    - vanish
    - premiumvanish

SlimeDog commented 7 months ago

I do not understand

# - Default-World: the default world where the scoreboard appears

Does the scoreboard not appear in all worlds? How to make that happen?

PanetiX commented 7 months ago

Hi there, please kindly test this version and give me feedback, thanks: RealScoreboard.jar.zip

nope don't work, too

joserodpt commented 7 months ago

I do not understand
# - Default-World: the default world where the scoreboard appears
Does the scoreboard not appear in all worlds? How to make that happen?

Copy the scoreboard entry and modify the world

joserodpt commented 7 months ago

Hi there, please kindly test this version and give me feedback, thanks: RealScoreboard.jar.zip

nope don't work, too

What didn't work? More feedback is needed

PanetiX commented 7 months ago

Hi there, please kindly test this version and give me feedback, thanks: RealScoreboard.jar.zip

nope don't work, too

What didn't work? More feedback is needed

i uploaded you new version but nothing changed. Player's didn't see a scoreboard until i use /realscoreboard setsb default /realscoreboard toggle /realscoreboard toggle

but when they rejoin the server the scoreboard is not visible and i need to re-enter the commands.

joserodpt commented 7 months ago

Hi there, please kindly test this version and give me feedback, thanks: RealScoreboard.jar.zip

nope don't work, too

What didn't work? More feedback is needed

i uploaded you new version but nothing changed. Player's didn't see a scoreboard until i use /realscoreboard setsb default /realscoreboard toggle /realscoreboard toggle

but when they rejoin the server the scoreboard is not visible and i need to re-enter the commands.

Console logs? Scoreboard config?

PanetiX commented 7 months ago

scoreboards.yml:

Version: '2'
Scoreboards:
  default:
    Default: true
    Default-World: world
    Display-Name: '&7default'
    Permission: none
    Refresh:
      Scoreboard: 20
      Title: 20
      Title-Loop-Delay: 20
      Board-Loop-Delay: 30
    Title:
    - '&9&lCitybuild &2| &aOnline: &f%cmi_server_online%'
    Lines:
    - '&8 ⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊'
    - '&2 ▎ &a&lInformationen:'
    - '&2 ▎ &7Name: &a%cmi_user_name%'
    - '&2 ▎ &7Rang: &a%cmi_user_prefix%'
    - '&2 ▎ &7Taler: &a%cmi_user_balance_formatted%'
    - '&2 ▎ &7Spielzeit: &f%cmi_user_playtime_days% Tage %cmi_user_playtime_hours% Std.'
    - '&2 ▎ &7Quests: &f%quests_completed%/366'
    - '&2 ▎ &7Welt: &f%multiverse_world_alias%'
    - '%blank%'
    - '&6 ▎ &a&lBooster:'
    - '&6 ▎ &7Fly: %booster_fly_status% &f| &7Break: %booster_break_status% &f| &7XP: %booster_xp_status%'
    - '&6 ▎ &r%conditionaltext_booster-score-fly%%conditionaltext_booster-score-break%%conditionaltext_booster-score-xp%'
    - '%blank%'
    - '&b ▎ &ediscord.craftplay.de'
  admin:
    Default: false
    Default-World: world
    Display-Name: '&7admin'
    Permission: realscoreboard.scoreboardadmin
    Refresh:
      Scoreboard: 20
      Title: 20
      Title-Loop-Delay: 20
    Title:
    - '&9&lCitybuild &2| &aOnline: &f%cmi_server_online%'
    Lines:
    - '&8 ⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊'
    - '&2 ▎ &a%cmi_user_name% &f| &a%cmi_user_prefix% %cmi_user_vanished_symbol%'
    - '&2 ▎ &7Taler: &a%cmi_user_balance_formatted%'
    - '&2 ▎ &7Spielzeit: &f%cmi_user_playtime_days% Tage %cmi_user_playtime_hours% Std.'
    - '&2 ▎ &7Quests: &f%quests_completed%/366'
    - '&2 ▎ &7Welt: &f%multiverse_world_alias%'
    - '%blank%'
    - '&6 ▎ &a&lBooster:'
    - '&6 ▎ &7Fly: %booster_fly_status% &f| &7Break: %booster_break_status% &f| &7XP: %booster_xp_status%'
    - '&6 ▎ &r%conditionaltext_booster-score-fly%%conditionaltext_booster-score-break%%conditionaltext_booster-score-xp%'
    - '%blank%'
    - '&c ▎ &7Uptime: &f%cmi_server_uptime%'
    - '&c ▎ &7TPS: &f%server_tps_1_colored% &2| &7RAM: &f%server_ram_used%'
    - '&c ▎ &7Chunks: &f%server_total_chunks%'

config.yml:

Debug: false
Config:
  Prefix: '&a»&b&lCRAFTPLAY&7:&r '
  mcMMO-Support: false
  Check-for-Updates: false
  Use-Placeholders-In-Scoreboard-Titles: true
  RealScoreboard-Disabled-By-Default: false
  Auto-Hide-In-Vanish: true
  World-Scoreboard-Switch: true
  Animations:
    Loop-Delay: 20
  Reloaded: '&fScoreboard Konfiguration wurde &aneu geladen&f.'
  Hours:
    Formatting: HH:mm:ss
    Offset: 0
  Messages:
    Scoreboard-Toggle:
      ON: '&7Das Scoreboard wird &aangezeigt&7.'
      OFF: '&7Das Scoreboard wird &causgeblendet&7.'
  Disabled-Worlds:
  - testWorld
  - ExampleWorld2
  Bypass-Worlds:
  - skywarsLobby
  Vanish-Commands:
  - pv
  - vanish
  - premiumvanish
Version: '16'

[16:19:44] [Server thread/INFO]: [RealScoreboard] Loading server plugin RealScoreboard v1.4.1
[16:20:34] [Server thread/INFO]: [RealScoreboard] Enabling RealScoreboard v1.4.1
[16:20:34] [Server thread/INFO]: [RealScoreboard]    ____            _ ____                     _                         _
[16:20:34] [Server thread/INFO]: [RealScoreboard]   |  _ \ ___  __ _| / ___|  ___ ___  _ __ ___| |__   ___   __ _ _ __ __| |
[16:20:34] [Server thread/INFO]: [RealScoreboard]   | |_) / _ \/ _` | \___ \ / __/ _ \| '__/ _ \ '_ \ / _ \ / _` | '__/ _` |
[16:20:34] [Server thread/INFO]: [RealScoreboard]   |  _ <  __/ (_| | |___) | (_| (_) | | |  __/ |_) | (_) | (_| | | | (_| |
[16:20:34] [Server thread/INFO]: [RealScoreboard]   |_| \_\___|\__,_|_|____/ \___\___/|_|  \___|_.__/ \___/ \__,_|_|  \__,_|
[16:20:34] [Server thread/INFO]: [RealScoreboard]   Made by: JoseGamer_PT                             Version: 1.4.1
[16:20:34] [Server thread/INFO]: [RealScoreboard] 
[16:20:34] [Server thread/INFO]: [RealScoreboard] Loaded 2 scoreboards.
[16:20:34] [Server thread/INFO]: [RealScoreboard] Your config version: 16
[16:20:34] [Server thread/INFO]: [RealScoreboard] Server version: 1.20.4-R0.1-SNAPSHOT
[16:20:34] [Server thread/INFO]: [RealScoreboard] Finished loading in 0.119 seconds.
[16:20:34] [Server thread/INFO]: [RealScoreboard] <------------------ RealScoreboard v1.4.1 ------------------>

SlimeDog commented 7 months ago

Does the scoreboard not appear in all worlds? How to make that happen?

Copy the scoreboard entry and modify the world

Please make a configuration node that specifies all the applicable worlds, or disabled worlds. I do not want to make 23 duplicate entries. That was not necessary in RS 1.3.4 and previous. Something like

  default:
    Default: true
    Enabled-Worlds: [] # meaning all worlds
    Disabled-Worlds: []

or

  default:
    Default: true
    Worlds: *

or (not preferred, but at least clear)

  default:
    Default: true
    Worlds:
    - world
    - world_nether
    - world_the_end

SlimeDog commented 7 months ago

Updates based on (re)testing RS 1.4.1

With nothing changed from the above, the default scoreboard is now displayed in all worlds, across multiple sessions. Please explain. Is it Scoreboards.default.Default: true or something else?
I see that the message prefix is controlled by a configuration entry Config.Prefix. For consistency with other messages (and most other plugins), it should be
```
Config:
Prefix: '[RealScoreboard] '
```
The issue with conversion of Scoreboards.default.Refresh.Scoreboard remains.
I think other issues that I raised have been resolved. I cannot speak for PanetiX, of course.

joserodpt commented 7 months ago

With nothing changed from the above, the default scoreboard is now displayed in all worlds, across multiple sessions. > Please explain. Is it Scoreboards.default.Default: true or something else?

The default is displayed for every player without permissions. If the player has a permission to a certain scoreboard, it will be overriden.

I see that the message prefix is controlled by a configuration entry Config.Prefix. For consistency with other messages (and most other plugins

Fixed in latest commit

The issue with conversion of Scoreboards.default.Refresh.Scoreboard remains.

Where did you get the number 3 from? config?

joserodpt commented 7 months ago

scoreboards.yml:

Version: '2' Scoreboards: default: Default: true Default-World: world Display-Name: '&7default' Permission: none Refresh: Scoreboard: 20 Title: 20 Title-Loop-Delay: 20 Board-Loop-Delay: 30 Title: - '&9&lCitybuild &2| &aOnline: &f%cmi_server_online%' Lines: - '&8 ⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊' - '&2 ▎ &a&lInformationen:' - '&2 ▎ &7Name: &a%cmi_user_name%' - '&2 ▎ &7Rang: &a%cmi_user_prefix%' - '&2 ▎ &7Taler: &a%cmi_user_balance_formatted%' - '&2 ▎ &7Spielzeit: &f%cmi_user_playtime_days% Tage %cmi_user_playtime_hours% Std.' - '&2 ▎ &7Quests: &f%quests_completed%/366' - '&2 ▎ &7Welt: &f%multiverse_world_alias%' - '%blank%' - '&6 ▎ &a&lBooster:' - '&6 ▎ &7Fly: %booster_fly_status% &f| &7Break: %booster_break_status% &f| &7XP: %booster_xp_status%' - '&6 ▎ &r%conditionaltext_booster-score-fly%%conditionaltext_booster-score-break%%conditionaltext_booster-score-xp%' - '%blank%' - '&b ▎ &ediscord.craftplay.de' admin: Default: false Default-World: world Display-Name: '&7admin' Permission: realscoreboard.scoreboardadmin Refresh: Scoreboard: 20 Title: 20 Title-Loop-Delay: 20 Title: - '&9&lCitybuild &2| &aOnline: &f%cmi_server_online%' Lines: - '&8 ⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊⚊' - '&2 ▎ &a%cmi_user_name% &f| &a%cmi_user_prefix% %cmi_user_vanished_symbol%' - '&2 ▎ &7Taler: &a%cmi_user_balance_formatted%' - '&2 ▎ &7Spielzeit: &f%cmi_user_playtime_days% Tage %cmi_user_playtime_hours% Std.' - '&2 ▎ &7Quests: &f%quests_completed%/366' - '&2 ▎ &7Welt: &f%multiverse_world_alias%' - '%blank%' - '&6 ▎ &a&lBooster:' - '&6 ▎ &7Fly: %booster_fly_status% &f| &7Break: %booster_break_status% &f| &7XP: %booster_xp_status%' - '&6 ▎ &r%conditionaltext_booster-score-fly%%conditionaltext_booster-score-break%%conditionaltext_booster-score-xp%' - '%blank%' - '&c ▎ &7Uptime: &f%cmi_server_uptime%' - '&c ▎ &7TPS: &f%server_tps_1_colored% &2| &7RAM: &f%server_ram_used%' - '&c ▎ &7Chunks: &f%server_total_chunks%'

config.yml: Debug: false Config: Prefix: '&a»&b&lCRAFTPLAY&7:&r ' mcMMO-Support: false Check-for-Updates: false Use-Placeholders-In-Scoreboard-Titles: true RealScoreboard-Disabled-By-Default: false Auto-Hide-In-Vanish: true World-Scoreboard-Switch: true Animations: Loop-Delay: 20 Reloaded: '&fScoreboard Konfiguration wurde &aneu geladen&f.' Hours: Formatting: HH:mm:ss Offset: 0 Messages: Scoreboard-Toggle: ON: '&7Das Scoreboard wird &aangezeigt&7.' OFF: '&7Das Scoreboard wird &causgeblendet&7.' Disabled-Worlds:

testWorld

ExampleWorld2 Bypass-Worlds:

skywarsLobby Vanish-Commands:

pv

vanish

premiumvanish Version: '16'

Log. [16:19:44] [Server thread/INFO]: [RealScoreboard] Loading server plugin RealScoreboard v1.4.1 [16:20:34] [Server thread/INFO]: [RealScoreboard] Enabling RealScoreboard v1.4.1 [16:20:34] [Server thread/INFO]: [RealScoreboard] _ _ [16:20:34] [Server thread/INFO]: [RealScoreboard] | \ _ _ | / **| _| | _ _| | [16:20:34] [Server thread/INFO]: [RealScoreboard] | |) / / ` | _ \ / / _ | '/ \ ' \ / \ / | '**/ _ | [16:20:34] [Server thread/INFO]: [RealScoreboard] | _ < / (_| | |_) | (| () | | | / |) | () | (| | | | (| | [16:20:34] [Server thread/INFO]: [RealScoreboard] |_| |,||__/ _**/|| **|./ _/ ,|| ,_| [16:20:34] [Server thread/INFO]: [RealScoreboard] Made by: JoseGamer_PT Version: 1.4.1 [16:20:34] [Server thread/INFO]: [RealScoreboard] [16:20:34] [Server thread/INFO]: [RealScoreboard] Loaded 2 scoreboards. [16:20:34] [Server thread/INFO]: [RealScoreboard] Your config version: 16 [16:20:34] [Server thread/INFO]: [RealScoreboard] Server version: 1.20.4-R0.1-SNAPSHOT [16:20:34] [Server thread/INFO]: [RealScoreboard] Finished loading in 0.119 seconds. [16:20:34] [Server thread/INFO]: [RealScoreboard] <------------------ RealScoreboard v1.4.1 ------------------>

Please send individual files all in a .zip folder to not deformat them

SlimeDog commented 7 months ago

Where did you get the number 3 from? config?

It was in my original config.yml

#SpigotMC - https://www.spigotmc.org/resources/realscoreboard-1-13-to-1-19-2.22928/
#Discord Server - https://discord.gg/t7gfnYZKy8
#bStats - https://bstats.org/plugin/bukkit/RealScoreboard/10080
#HEX Color Formats: https://github.com/Iridium-Development/IridiumColorAPI
#API for Developers: https://github.com/joserodpt/RealScoreboard/blob/master/api.md
Debug: false
Config:
  ItemAdder-Support: false
  mcMMO-Support: false
  Check-for-Updates: false
  Prefix: 'RealScoreboard | '
  Reloaded: 'The config has been reloaded.'
  Use-Placeholders-In-Scoreboard-Titles: true
  RealScoreboard-Disabled-By-Default: false
  Auto-Hide-In-Vanish: true
  Hours:
    Formatting: 'HH:mm:ss'
    Offset: 0
  Messages:
    Scoreboard-Toggle:
      'ON': 'Scoreboard turned ON.'
      'OFF': 'Scoreboard turned OFF.'
  Animations:
    Title-Delay: 20
    Loop-Delay: 20
  Scoreboard-Refresh: 3
  Disabled-Worlds: []
  Bypass-Worlds: []
  Scoreboard:
    world:
      default:
        Switch-Timer: 35
        Boards:
          admin:
            Title:
              - '&7□□□□□□□□ &l%server_name%&r&7 □□□□□□□□'
            Lines:
              - '&8world:    &7%multiverse_world_alias%'
              - '&8location: &7%player_x% %player_y% %player_z%'
              - '&8chunk:    &7%coordinatetool_chunk%'
              - '&8region:   &7%coordinatetool_file%'
              - '&8b_biome:  &7%biomeremap_biome_name%'
              - '&8p_biome:  &7%player_biome%'
              - '&8time:     &7%player_world_time_24%'
              - '&8tps:      &7%server_tps_1% %server_tps_5%'
              - ''
              - '&8health:   &7%player_health%'
              - '&8deaths:   &7%statistic_deaths% (%plan_player_death_count%)'
              - '&8points$:  &7%vault_eco_balance%'
              - '&8group:    &7%luckperms_primary_group_name%'
Version: 15

So I think that

Config:
  Scoreboard-Refresh: 3

should be converted to

Scoreboards:
  default:
    Refresh:
      Scoreboard: 3

in scoreboards.yml.

SlimeDog commented 7 months ago

Please send individual files all in a .zip folder to not deformat them

Or just enclose the YAML between lines that contain only ```. So

``` YOUR YAML CONTENT ```

joserodpt commented 7 months ago

Config

You're right, thanks for providing your config again! Please test now this version: RealScoreboard.jar.zip

SlimeDog commented 7 months ago

The second RS 1.4.1 (you shouldn't reuse version strings) produces

  default:
    Default: true
    Default-World: world
    Display-Name: '&7default'
    Permission: none
    Refresh:
      Scoreboard: 0
      Title: 0
      Title-Loop-Delay: 20

so clearly not correct.

SlimeDog commented 7 months ago

My single-scoreboard system works. It does not adequately test 1.3.4-1.4.x conversion. I hope you will continue to debug the conversion algorithm with users for whom it doesn't work.

PanetiX commented 7 months ago

i edited my config post :D

PanetiX commented 6 months ago

i tested a little arround. When i type the correct world name the scoreboard works. But how i can add all worlds to the list? When players change the world, the scoreboard dissapears... I think this update is a little bit messy, before everything works fine :/ since the last update there are just problems with this plugin.

PanetiX commented 6 months ago

Does the scoreboard not appear in all worlds? How to make that happen?

Copy the scoreboard entry and modify the world

Please make a configuration node that specifies all the applicable worlds, or disabled worlds. I do not want to make 23 duplicate entries. That was not necessary in RS 1.3.4 and previous. Something like
  default:
    Default: true
    Enabled-Worlds: [] # meaning all worlds
    Disabled-Worlds: []
or
  default:
    Default: true
    Worlds: *
or (not preferred, but at least clear)
  default:
    Default: true
    Worlds:
    - world
    - world_nether
    - world_the_end

i think this is a great solution.

joserodpt commented 6 months ago

Hi there, I just implemented that system: default: Default: true Default-World: world Other-Worlds:

'*' or default: Default: true Default-World: world Other-Worlds:
'coolWorld'

Please kindly test this debug build: RealScoreboard.jar.zip

SlimeDog commented 6 months ago

Thanks. Testing the latest RS 1.4.1, as requested:

The default scoreboards.yml in the JAR does not contain the Other-Worlds configuration node. It should.
Running the new JAR did not produce the Other-Worlds configuration node. I'm OK with that -- my own plugins do not modify existing configuration files -- but others may have different opinions.

I edited scoreboards.yml manually to include the Other-Worlds configuration node

Version: 2
Scoreboards:
default:
Default: true
Default-World: world
Other-Worlds: 
- '*'
Display-Name: 'Admin Scoreboard'
Permission: realscoreboard.admin
Refresh:
  Scoreboard: 3
  Title: 20
  Title-Loop-Delay: 5
  Board-Loop-Delay: 20
Boards:
  admin:
    Title:
    - '&7□□□□□□□□ &l%server_name%&r&7 □□□□□□□□'
    Lines:
    - '&8world:    &7%multiverse_world_alias%'
    - '&8location: &7%player_x% %player_y% %player_z%'
    - '&8chunk:    &7%coordinatetool_chunk%'
    - '&8region:   &7%coordinatetool_file%'
    - '&8b_biome:  &7%biomeremap_biome_name%'
    - '&8p_biome:  &7%player_biome%'
    - '&8time:     &7%player_world_time_24%'
    - '&8tps:      &7%server_tps_1% %server_tps_5%'
    - ''
    - '&8health:   &7%player_health%'
    - '&8deaths:   &7%statistic_deaths% (%plan_player_death_count%)'
    - '&8points$:  &7%vault_eco_balance%'
    - '&8group:    &7%luckperms_primary_group_name%'

After rsb reload, multiple errors were generated in the console/log

java.lang.NullPointerException: Cannot invoke "fr.mrmicky.fastboard.FastBoard.updateLines(java.util.Collection)" because the return value of "joserodpt.realscoreboard.api.scoreboard.RPlayerHook.access$300(joserodpt.realscoreboard.api.scoreboard.RPlayerHook)" is null
    at joserodpt.realscoreboard.api.scoreboard.RPlayerHook$1.run(RPlayerHook.java:68) ~[RealScoreboard-1.4.1.jar:?]
    at org.bukkit.craftbukkit.v1_20_R3.scheduler.CraftTask.run(CraftTask.java:101) ~[paper-1.20.4.jar:git-Paper-496]
    at org.bukkit.craftbukkit.v1_20_R3.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:57) ~[paper-1.20.4.jar:git-Paper-496]
    at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22) ~[paper-1.20.4.jar:?]
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) ~[?:?]
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) ~[?:?]
    at java.lang.Thread.run(Thread.java:1570) ~[?:?]

I stopped the server and restarted it, with the same scoreboards.yml. The scoreboard title appeared immediately, but it took several seconds for the lines to appear, and for a while the flicker was severe. Eventually, the scoreboard stabilized and appeared normally.

So I guess you could say that Other-Worlds works, with the caveats noted above.

joserodpt commented 6 months ago

Just published a new update, version 1.4.2 on spigot. Feedback is appreciated, thanks!

SlimeDog commented 6 months ago

Testing RS 1.4.2.

On changing worlds for the first time, for a while the flicker was severe, flipping between my previous location (in the previous world) and my current location (in the new world). Eventually, the scoreboard stabilized and appeared normally.

joserodpt / RealScoreboard

RS 1.3.4 to 1.4 conversion is broken #69