search

josesamuel / remoter

Remoter - An alternative to Android AIDL for Android Remote IPC services using plain java interfaces
Apache License 2.0
84 stars 14 forks source link

Fix parameter collisions #3

Closed F43nd1r closed 5 years ago

F43nd1r commented 5 years ago

I had the problem that methods with a parameter called data would not compile, because remoter uses that name in the proxy.

I fixed that by renaming all parameters in the proxy. Unfortunalety, that required changes in all ParamBuilders.

josesamuel commented 5 years ago

Thank you for the pr and for bringing this issue.

Unfortunately I am not merging this version, instead i am adding a simpler fix to address this issue with very limited changes.

I would also appreciate if you can keep the line endings the same so that the diff doesnt end up showing all the file has changed making it hard to review.